Removed duplicate line and added comment on variable#15362
Merged
magento-engcom-team merged 2 commits intomagento:2.2-developfrom May 22, 2018
Merged
Removed duplicate line and added comment on variable#15362magento-engcom-team merged 2 commits intomagento:2.2-developfrom
magento-engcom-team merged 2 commits intomagento:2.2-developfrom
Conversation
Contributor
|
Hi @vgelani, thank you for your PR! I would say we can also remove the second comment |
Contributor
Author
|
@mzeis Yes. I also think about it. Let me remove it. |
mzeis
approved these changes
May 19, 2018
Contributor
|
Hi @mzeis, thank you for the review. |
Contributor
|
Hi @vgelani. Thank you for your contribution. Please, consider porting this solution across release lines. |
This was referenced May 23, 2018
This was referenced Jun 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removed duplicate code and added comment on variable.
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist