Skip to content

Add statement to 'beforeSave' method to allow app:config:import#14829

Merged
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
bmxmale:BRAINTREE_APP_CONFIG_IMPORT
Apr 27, 2018
Merged

Add statement to 'beforeSave' method to allow app:config:import#14829
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
bmxmale:BRAINTREE_APP_CONFIG_IMPORT

Conversation

@bmxmale
Copy link
Copy Markdown

@bmxmale bmxmale commented Apr 24, 2018

Fix to app:config:import for beforeSave method on Braintree CountryCreditCard class.

Description

magento@04065890c38d:/srv/magento2$ php bin/magento app:config:import
Processing configurations data from configuration file...
Import failed: Warning: Invalid argument supplied for foreach() in /srv/magento2/vendor/magento/module-braintree/Model/Adminhtml/System/Config/CountryCreditCard.php on line 70

Manual testing scenarios

  1. php bin/magento app:config:dump
  2. change some configs
  3. php bin/magento app:config:import

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Copy Markdown
Contributor

magento-cicd2 commented Apr 24, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Copy Markdown
Contributor

@bmxmale thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team magento-engcom-team merged commit d5de354 into magento:2.2-develop Apr 27, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @bmxmale. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants