Skip to content

[Forwardport] Add statement to 'beforeSave' method to allow app:config:import#3

Merged
adrian-martinez-interactiv4 merged 1 commit into2.3-developfrom
2.3-develop-PR-port-14829
Oct 8, 2018
Merged

[Forwardport] Add statement to 'beforeSave' method to allow app:config:import#3
adrian-martinez-interactiv4 merged 1 commit into2.3-developfrom
2.3-develop-PR-port-14829

Conversation

@adrian-martinez-interactiv4
Copy link
Copy Markdown
Owner

Original Pull Request

magento#14829

Fix to app:config:import for beforeSave method on Braintree CountryCreditCard class.

Description

magento@04065890c38d:/srv/magento2$ php bin/magento app:config:import
Processing configurations data from configuration file...
Import failed: Warning: Invalid argument supplied for foreach() in /srv/magento2/vendor/magento/module-braintree/Model/Adminhtml/System/Config/CountryCreditCard.php on line 70

Manual testing scenarios

  1. php bin/magento app:config:dump
  2. change some configs
  3. php bin/magento app:config:import

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@adrian-martinez-interactiv4 adrian-martinez-interactiv4 merged commit 91b72e7 into 2.3-develop Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant