Skip to content

[Forwardport] Add statement to 'beforeSave' method to allow app:config:import#15071

Merged
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
adrian-martinez-interactiv4:2.3-develop-PR-port-14829
May 12, 2018
Merged

[Forwardport] Add statement to 'beforeSave' method to allow app:config:import#15071
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
adrian-martinez-interactiv4:2.3-develop-PR-port-14829

Conversation

@adrian-martinez-interactiv4
Copy link
Copy Markdown
Contributor

Original Pull Request

#14829

Fix to app:config:import for beforeSave method on Braintree CountryCreditCard class.

Description

magento@04065890c38d:/srv/magento2$ php bin/magento app:config:import
Processing configurations data from configuration file...
Import failed: Warning: Invalid argument supplied for foreach() in /srv/magento2/vendor/magento/module-braintree/Model/Adminhtml/System/Config/CountryCreditCard.php on line 70

Manual testing scenarios

  1. php bin/magento app:config:dump
  2. change some configs
  3. php bin/magento app:config:import

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added this to the May 2018 milestone May 8, 2018
@magento-engcom-team magento-engcom-team added Release Line: 2.3 Partner: Interactiv4 Pull Request is created by partner Interactiv4 partners-contribution Pull Request is created by Magento Partner Progress: accept labels May 8, 2018
@magento-engcom-team magento-engcom-team merged commit 91b72e7 into magento:2.3-develop May 12, 2018
magento-engcom-team pushed a commit that referenced this pull request May 12, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @adrian-martinez-interactiv4. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Partner: Interactiv4 Pull Request is created by partner Interactiv4 partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants