Skip to content

[Forwardport] Add statement to 'beforeSave' method to allow app:config:import#15051

Merged
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
rogyar:2.3-config-import-country-cart
May 9, 2018
Merged

[Forwardport] Add statement to 'beforeSave' method to allow app:config:import#15051
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
rogyar:2.3-config-import-country-cart

Conversation

@rogyar
Copy link
Copy Markdown
Contributor

@rogyar rogyar commented May 8, 2018

Original PR: #14829

Fix to app:config:import for beforeSave method on Braintree CountryCreditCard class.

Description

magento@04065890c38d:/srv/magento2$ php bin/magento app:config:import
Processing configurations data from configuration file...
Import failed: Warning: Invalid argument supplied for foreach() in /srv/magento2/vendor/magento/module-braintree/Model/Adminhtml/System/Config/CountryCreditCard.php on line 70

Manual testing scenarios

  1. php bin/magento app:config:dump
  2. change some configs
  3. php bin/magento app:config:import

@magento-engcom-team magento-engcom-team added this to the May 2018 milestone May 8, 2018
@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept labels May 8, 2018
@magento-engcom-team magento-engcom-team merged commit e07e762 into magento:2.3-develop May 9, 2018
magento-engcom-team pushed a commit that referenced this pull request May 9, 2018
@VladimirZaets
ENGCOM-1469: [Forwardport] Add statement to 'beforeSave' method to al…
5728b3c 
…low app:config:import #15051
@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented May 9, 2018

Hi @rogyar. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@VladimirZaets VladimirZaets

Labels

Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3

Projects

None yet

Milestone

May 2018

Development

Successfully merging this pull request may close these issues.

3 participants

@rogyar @magento-engcom-team @VladimirZaets