[Backport] Fix meta title property#16948
Merged
magento-engcom-team merged 3 commits intomagento:2.1-developfrom Jul 21, 2018
ronak2ram:2.1-develop-PR-port-11368
Merged
[Backport] Fix meta title property#16948magento-engcom-team merged 3 commits intomagento:2.1-developfrom ronak2ram:2.1-develop-PR-port-11368
magento-engcom-team merged 3 commits intomagento:2.1-developfrom
ronak2ram:2.1-develop-PR-port-11368
Conversation
aleron75
approved these changes
Jul 20, 2018
Contributor
|
Hi @aleron75, thank you for the review. |
Contributor
|
Hi @ronak2ram. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#11368
Description
If, inside a controller you try to set metadata title with:
you will get an error on frontend:
Recoverable Error: Object of class Magento\Framework\View\Page\Title could not be converted to string...
becouse
processMetadataContentwill return an istance ofMagento\Framework\View\Page\Titleinstead of a string.Fixed Issues (if relevant)
Manual testing scenarios
Scenario 1
executefunction add:Scenario 2
executefunction add:Contribution checklist