Skip to content

Add metadata title in unit test#16333

Merged
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
slackerzz:backport-11368
Jun 29, 2018
Merged

Add metadata title in unit test#16333
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
slackerzz:backport-11368

Conversation

@slackerzz
Copy link
Copy Markdown
Member

Description

Trying to backport #11368 i've found that @phoenix128 fixed the same issue in 1413d65

This pull request only add test coverage to metadata title

Fixed Issues (if relevant)

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: MageSpecialist partners-contribution Pull Request is created by Magento Partner labels Jun 22, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @slackerzz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

Copy link
Copy Markdown
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @slackerzz! And big thanks for making this quick investigation.

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-2106 has been created to process this Pull Request

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @slackerzz. Thank you for your contribution.
The changes from your Pull Request should be available with the upcoming 2.2.6 release.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants