Skip to content

Unable to render page when 'meta title' page config param is set #issue-2956#15908

Closed
gelanivishal wants to merge 1 commit intomagento:2.2-developfrom
gelanivishal:issue-2
Closed

Unable to render page when 'meta title' page config param is set #issue-2956#15908
gelanivishal wants to merge 1 commit intomagento:2.2-developfrom
gelanivishal:issue-2

Conversation

@gelanivishal
Copy link
Copy Markdown
Contributor

Description

Fixed. Added a check to to see if returned content is object or not. As objects will never be converted to string and will throw error for str_replace at line 125

Fixed Issues (if relevant)

  1. Unable to render page when 'meta title' page config param is set #2956: Unable to render page when 'meta title' page config param is set

Manual testing scenarios

  1. Use the "Steps to reproduce" in original issue.
  2. View the source generated in browser.
  3. You will be able to see <meta name="title" content="some meta title"/> in source code.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@dmanners
Copy link
Copy Markdown
Contributor

dmanners commented Jun 7, 2018

Hi @vgelani thank you for this Pull Request. This issue has already been fixed in 2.3-develop via the PR #11368

I would recommend that you use the backporting tool to incorporate the same fix across 2.2-develop and 2.1-develop rather than fixing this issue in another way.

Feel free to create a new PR using the backporting tool for 2.2 and 2.1.

@dmanners dmanners closed this Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants