fix(build): reduce turbo cache invalidation fanout#2538
fix(build): reduce turbo cache invalidation fanout#2538Yradex merged 5 commits intolynx-family:mainfrom
Conversation
Move shared builds away from repo-scoped //#build dependencies so unrelated website edits stop invalidating unrelated packages. Document the guardrails and verification trail for future Turbo config changes.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
✅ Files skipped from review due to trivial changes (7)
📝 WalkthroughWalkthroughAdds Turbo cache/invalidation guidance; removes repo-scoped Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b520637b53
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Make web-explorer wait for the root TypeScript outputs it consumes and include rsbuild-plugin config files in the Turbo hash so clean CI jobs and config-only edits cannot reuse stale artifacts.
Add missing rslib-related files to package build inputs so config-only edits cannot replay stale cached artifacts across the remaining Turbo-managed rslib packages.
colinaaa
requested review from
HuJean,
Yradex,
hzy,
luhc228 and
upupming
as code owners
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6fdf5d3032
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Merging this PR will not alter performance
Comparing 
Footnotes
|
React External#823 Bundle Size — 680.27KiB (-0.02%).6fdf5d3(current) vs caadd3b main#818(baseline) Bundle metrics
|
| Current #823 |
Baseline #818 |
|
|---|---|---|
 Initial JS |
0B |
0B |
| Initial CSS |
0B |
0B |
 Cache Invalidation |
39.71% |
39.7% |
| Chunks |
0 |
0 |
| Assets |
3 |
3 |
| Modules |
17 |
17 |
| Duplicate Modules |
5 |
5 |
| Duplicate Code |
8.59% |
8.59% |
| Packages |
0 |
0 |
| Duplicate Packages |
0 |
0 |
Bundle size by type 1 change 
1 improvement
| Current #823 |
Baseline #818 |
|
|---|---|---|
| Other |
680.27KiB (-0.02%) |
680.41KiB |
Bundle analysis report Branch colinaaa:build/turbo-cache-fanou... Project dashboard
Generated by RelativeCI Documentation Report issue
Web Explorer#9281 Bundle Size — 900.02KiB (0%).6fdf5d3(current) vs caadd3b main#9275(baseline) Bundle metrics
|
| Current #9281 |
Baseline #9275 |
|
|---|---|---|
| Initial JS |
44.46KiB |
44.46KiB |
| Initial CSS |
2.22KiB |
2.22KiB |
| Cache Invalidation |
0% |
0% |
| Chunks |
9 |
9 |
| Assets |
11 |
11 |
| Modules |
227(-1.3%) |
230 |
| Duplicate Modules |
11 |
11 |
| Duplicate Code |
27.29%(+0.04%) |
27.28% |
| Packages |
10 |
10 |
| Duplicate Packages |
0 |
0 |
Bundle size by type no changes
| Current #9281 |
Baseline #9275 |
|
|---|---|---|
| JS |
495.88KiB |
495.88KiB |
| Other |
401.92KiB |
401.92KiB |
| CSS |
2.22KiB |
2.22KiB |
Bundle analysis report Branch colinaaa:build/turbo-cache-fanou... Project dashboard
Generated by RelativeCI Documentation Report issue
React MTF Example#840 Bundle Size — 196.54KiB (-0.02%).6fdf5d3(current) vs caadd3b main#834(baseline) Bundle metrics
|
| Current #840 |
Baseline #834 |
|
|---|---|---|
| Initial JS |
0B |
0B |
| Initial CSS |
0B |
0B |
| Cache Invalidation |
43.42% |
43.4% |
| Chunks |
0 |
0 |
| Assets |
3 |
3 |
| Modules |
173(-0.57%) |
174 |
| Duplicate Modules |
66 |
66 |
| Duplicate Code |
44.08%(+0.09%) |
44.04% |
| Packages |
2 |
2 |
| Duplicate Packages |
0 |
0 |
Bundle size by type 1 change 1 improvement
| Current #840 |
Baseline #834 |
|
|---|---|---|
| IMG |
111.23KiB |
111.23KiB |
| Other |
85.31KiB (-0.05%) |
85.35KiB |
Bundle analysis report Branch colinaaa:build/turbo-cache-fanou... Project dashboard
Generated by RelativeCI Documentation Report issue
React Example#7708 Bundle Size — 225.38KiB (-0.02%).6fdf5d3(current) vs caadd3b main#7702(baseline) Bundle metrics
|
| Current #7708 |
Baseline #7702 |
|
|---|---|---|
| Initial JS |
0B |
0B |
| Initial CSS |
0B |
0B |
| Cache Invalidation |
35.34% |
35.33% |
| Chunks |
0 |
0 |
| Assets |
4 |
4 |
| Modules |
179(-0.56%) |
180 |
| Duplicate Modules |
69 |
69 |
| Duplicate Code |
44.57%(+0.07%) |
44.54% |
| Packages |
2 |
2 |
| Duplicate Packages |
0 |
0 |
Bundle size by type 1 change 1 improvement
| Current #7708 |
Baseline #7702 |
|
|---|---|---|
| IMG |
145.76KiB |
145.76KiB |
| Other |
79.63KiB (-0.05%) |
79.67KiB |
Bundle analysis report Branch colinaaa:build/turbo-cache-fanou... Project dashboard
Generated by RelativeCI Documentation Report issue
PR #2538 dropped `//#build` from `build.dependsOn`. `//#build` runs `tsc --build`, which produces composite-project `lib/` outputs that several workspace packages declare as their public types (`@lynx-js/rspeedy` → `./lib/index.d.ts`, etc.). `//#build` still runs as part of `pnpm turbo build` (no filter), but now in parallel with package builds. Two packages whose `tsgo` dts generation imports types from `lib/` race against `//#build`: - `@lynx-js/config-rsbuild-plugin` → imports `@lynx-js/rspeedy`, `@lynx-js/template-webpack-plugin` - `@lynx-js/reactlynx-testing-library` → imports `@lynx-js/rspeedy` When the race is lost, builds fail with `TS2307: Cannot find module …`. Add `//#build` to those two packages' own `dependsOn` (rather than the global `build.dependsOn`) so they wait for `tsc --build` without re-introducing the cache fanout #2538 was avoiding. Verified: `find packages -name "*.tsbuildinfo" -delete && find packages -type d -name lib -exec rm -rf {} + && pnpm turbo build --force` succeeds end-to-end (49/49 tasks).
## Summary [#2538](#2538) dropped `//#build` from `build.dependsOn` to reduce cache fanout. `//#build` runs the root `tsc --build`, which produces the composite-project `lib/` outputs that several workspace packages declare as their public types: - `@lynx-js/rspeedy` → `"types": "./lib/index.d.ts"` - `@lynx-js/template-webpack-plugin`, `@lynx-js/web-rsbuild-server-middleware`, etc. `//#build` still runs as part of `pnpm turbo build` (no filter), but now in parallel with package builds. Two packages whose `tsgo` dts generation imports types from those `lib/` outputs race against `//#build`: - `@lynx-js/config-rsbuild-plugin` (imports `@lynx-js/rspeedy`, `@lynx-js/template-webpack-plugin` in `LynxConfigWebpackPlugin.ts` / `pluginLynxConfig.ts`) - `@lynx-js/reactlynx-testing-library` (imports `@lynx-js/rspeedy` in `rstest-config.ts`) When the race is lost, those builds fail with `TS2307: Cannot find module …`. This was hit on PR #2543 ([build / Build (Ubuntu)](https://github.com/lynx-family/lynx-stack/actions/runs/25103126514/job/73557596812) — same failure on Windows). ## Fix Add `//#build` to the `dependsOn` of just the two affected packages (not to the global `build.dependsOn`) so they wait for `tsc --build` without re-introducing the cache fanout #2538 was avoiding. ## Test plan - [x] ```bash find packages -name "*.tsbuildinfo" -delete find packages -type d -name lib -exec rm -rf {} + pnpm turbo build --force ``` succeeds end-to-end (49/49 tasks). On `main` (without this fix) the same command fails on `@lynx-js/config-rsbuild-plugin#build` and `@lynx-js/reactlynx-testing-library#build`. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Resolved TypeScript type resolution failures in clean CI/build environments. * **Chores** * Ensured root composite build runs before package builds to enforce correct build ordering and artifact availability. * Added build configuration for a new extractor package and updated package build dependencies. * **Documentation** * Clarified maintenance guidance for produced/generated build artifacts and cache outputs. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
4 participants
Summary
globalDependenciesand trim redundant//#buildedges so unrelated edits stop fanning out across the build graph@lynx-js/web-explorer#builddepend on//#build, and hash the web plugin config so clean CI jobs do not consume missing or stale workspace artifactsrslib.config.tsinputs across Turbo-managed rslib packages, plus referenced helper files such asloaders/**andtsconfig.build.json, so config-only edits cannot replay stale cached outputsTest Plan
NODE_OPTIONS=\"--max-old-space-size=32768\" pnpm turbo build --summarize --output-logs=noneNODE_OPTIONS=\"--max-old-space-size=32768\" pnpm turbo build --filter=@lynx-js/gesture-runtime --force --summarize --output-logs=noneNODE_OPTIONS=\"--max-old-space-size=32768\" pnpm turbo build --filter=@lynx-js/gesture-runtime --summarize --output-logs=noneNODE_OPTIONS=\"--max-old-space-size=32768\" pnpm turbo build --filter=@lynx-js/motion --force --summarize --output-logs=noneNODE_OPTIONS=\"--max-old-space-size=32768\" pnpm turbo build --filter=@lynx-js/motion --summarize --output-logs=nonepnpm turbo build --filter @lynx-js/web-platform-rsbuild-plugin --summarizepnpm turbo build --filter @lynx-js/web-platform-rsbuild-plugin --dry=jsonpnpm turbo build --filter @lynx-js/web-explorer --force --summarizeafter removingdist/and*.tsbuildinfoforweb-core,web-elements,web-worker-rpc, andweb-explorerrslib.config.tsnow covers that config file inbuild.inputs, with extra helper files included whererslib.config.tsreaches outsidesrc/**Summary by CodeRabbit
Documentation
Chores