Skip to content

fix(genui): order a2ui catalog extractor build#2548

Closed
HuJean wants to merge 1 commit intomainfrom
fix/a2ui-catalog-extractor-build-order
Closed

fix(genui): order a2ui catalog extractor build#2548
HuJean wants to merge 1 commit intomainfrom
fix/a2ui-catalog-extractor-build-order

Conversation

@HuJean
Copy link
Copy Markdown
Collaborator

@HuJean HuJean commented Apr 30, 2026

Summary by CodeRabbit

  • Chores

    • Enforced explicit build dependency ordering and added the catalog extractor into the workspace build chain.
    • Declared build inputs/outputs and added TypeScript project references so sibling packages build in the expected order.
  • Documentation

    • Added guidance on build sequencing, cache/restore expectations, and a placeholder changeset for tracking.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).
  • Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 30, 2026

🦋 Changeset detected

Latest commit: 84985eb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f222edb6-aea8-47b6-a426-df764af9c661

📥 Commits

Reviewing files that changed from the base of the PR and between 005a527 and 84985eb.

📒 Files selected for processing (6)
  • .changeset/fix-a2ui-catalog-extractor-build-order.md
  • .github/a2ui-catalog.instructions.md
  • .github/lynx-stack.instructions.md
  • packages/genui/a2ui-catalog-extractor/turbo.json
  • packages/genui/a2ui/turbo.json
  • packages/rspeedy/plugin-config/tsconfig.build.json
✅ Files skipped from review due to trivial changes (4)
  • .changeset/fix-a2ui-catalog-extractor-build-order.md
  • packages/rspeedy/plugin-config/tsconfig.build.json
  • packages/genui/a2ui-catalog-extractor/turbo.json
  • .github/lynx-stack.instructions.md
🚧 Files skipped from review as they are similar to previous changes (2)
  • packages/genui/a2ui/turbo.json
  • .github/a2ui-catalog.instructions.md

📝 Walkthrough

Walkthrough

Adds a Turbo build for a2ui-catalog-extractor, makes packages/genui/a2ui build depend on that extractor, updates TypeScript project references for plugin-config, adds build-order instructions, and commits an empty changeset file.

Changes

Cohort / File(s) Summary
Turbo configs
packages/genui/a2ui/turbo.json, packages/genui/a2ui-catalog-extractor/turbo.json
packages/genui/a2ui/turbo.json: build now depends on @lynx-js/a2ui-catalog-extractor#build. Added packages/genui/a2ui-catalog-extractor/turbo.json defining a standalone build task with inputs and outputs: dist/**.
TypeScript build refs
packages/rspeedy/plugin-config/tsconfig.build.json
Added references entry pointing to ../../webpack/template-webpack-plugin/tsconfig.build.json to include sibling package in project-reference builds.
Docs & instructions
.github/a2ui-catalog.instructions.md, .github/lynx-stack.instructions.md
New guidance on requiring explicit Turbo task dependencies and declaring outputs for CLI packages; per-path instruction for packages/rspeedy/plugin-config/**/* about updating tsconfig.build.json references.
Changeset
.changeset/fix-a2ui-catalog-extractor-build-order.md
Added an empty changeset markdown file containing only frontmatter delimiters (no metadata or body).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • PupilTong
  • Sherry-hue
  • gaoachao
  • fzx2666-fz

Poem

🐰 I nibble tasks and stitch the thread,
A tiny extractor wakes from bed.
Dependencies hop into line,
Dist files bloom, the builds align.
Hooray — a tidy, punctual bind. 🥕

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix(genui): order a2ui catalog extractor build' directly corresponds to the main objective of the pull request, which is fixing the build order for the a2ui catalog extractor by adding explicit Turbo task dependencies.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/a2ui-catalog-extractor-build-order

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 6/8 reviews remaining, refill in 7 minutes and 40 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@HuJean HuJean force-pushed the fix/a2ui-catalog-extractor-build-order branch from 04ebb32 to 005a527 Compare April 30, 2026 02:09
@HuJean HuJean force-pushed the fix/a2ui-catalog-extractor-build-order branch from 005a527 to 84985eb Compare April 30, 2026 02:16
@HuJean HuJean closed this Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant