fix(build): make tsgo-dts packages depend on `//#build` by upupming · Pull Request #2546 · lynx-family/lynx-stack

upupming · 2026-04-29T12:18:16Z

Summary

#2538 dropped //#build from build.dependsOn to reduce cache fanout. //#build runs the root tsc --build, which produces the composite-project lib/ outputs that several workspace packages declare as their public types:

@lynx-js/rspeedy → "types": "./lib/index.d.ts"
@lynx-js/template-webpack-plugin, @lynx-js/web-rsbuild-server-middleware, etc.

//#build still runs as part of pnpm turbo build (no filter), but now in parallel with package builds. Two packages whose tsgo dts generation imports types from those lib/ outputs race against //#build:

@lynx-js/config-rsbuild-plugin (imports @lynx-js/rspeedy, @lynx-js/template-webpack-plugin in LynxConfigWebpackPlugin.ts / pluginLynxConfig.ts)
@lynx-js/reactlynx-testing-library (imports @lynx-js/rspeedy in rstest-config.ts)

When the race is lost, those builds fail with TS2307: Cannot find module …. This was hit on PR #2543 (build / Build (Ubuntu) — same failure on Windows).

Fix

Add //#build to the dependsOn of just the two affected packages (not to the global build.dependsOn) so they wait for tsc --build without re-introducing the cache fanout #2538 was avoiding.

Test plan

```bash
find packages -name "*.tsbuildinfo" -delete
find packages -type d -name lib -exec rm -rf {} +
pnpm turbo build --force

succeeds end-to-end (49/49 tasks). On `main` (without this fix) the same command fails on `@lynx-js/config-rsbuild-plugin#build` and `@lynx-js/reactlynx-testing-library#build`.

Summary by CodeRabbit

Bug Fixes
- Resolved TypeScript type resolution failures in clean CI/build environments.
Chores
- Ensured root composite build runs before package builds to enforce correct build ordering and artifact availability.
- Added build configuration for a new extractor package and updated package build dependencies.
Documentation
- Clarified maintenance guidance for produced/generated build artifacts and cache outputs.

changeset-bot · 2026-04-29T12:18:21Z

⚠️ No Changeset found

Latest commit: 80436e9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-04-29T12:18:31Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 287f8740-404d-4fdc-a90b-ec4a4f10b290

📥 Commits

Reviewing files that changed from the base of the PR and between 9358815 and dc1e01e.

📒 Files selected for processing (2)

.github/a2ui-catalog.instructions.md
packages/genui/a2ui-catalog-extractor/turbo.json

✅ Files skipped from review due to trivial changes (2)

.github/a2ui-catalog.instructions.md
packages/genui/a2ui-catalog-extractor/turbo.json

📝 Walkthrough

Walkthrough

Adds the root composite TypeScript build (//#build) as an explicit upstream dependency to package build tasks, adds a Changeset entry, introduces a Turbo config for a2ui-catalog-extractor, and documents Turbo outputs for generated artifacts. (47 words)

Changes

Cohort / File(s)	Summary
Changeset metadata `\.changeset/fix-turbo-tsc-deps.md`	Adds a Changeset describing the fix that ensures the root composite TypeScript build runs before package builds.
Turbo task dependency updates `packages/react/testing-library/turbo.json`, `packages/rspeedy/plugin-config/turbo.json`	Adds `//#build` to the `build.dependsOn` lists to force the root composite `tsc --build` to run upstream.
New package Turbo config `packages/genui/a2ui-catalog-extractor/turbo.json`	Adds a `build` task with `^build` dependency, inputs, and `dist/**` outputs for the new extractor package.
Docs / maintenance guidance `.github/a2ui-catalog.instructions.md`	Documents requirement to declare generated artifact directories (e.g., `dist/**`) as Turbo `build.outputs` when other packages consume those artifacts.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

fix(build): reduce turbo cache invalidation fanout #2538: Edits turbo build dependency edges involving the special root task //#build—directly related to adding //#build in package configs.
feat: init @lynx-js/config-rsbuild-plugin for Lynx Configs #2052: Introduced packages/rspeedy/plugin-config and its turbo.json—modifies the same file this change updates.
feat: add TypeDoc A2UI catalog extractor #2527: Adds/wires the @lynx-js/a2ui-catalog-extractor package which this PR configures and documents.

Suggested reviewers

HuJean
Yradex
hzy
colinaaa
luhc228

Poem

🐰 I hop through configs, tidy and spry,
//#build leads the dance before packages fly.
Dist and lib now wait in their place,
CI smiles back with a tidy embrace.
✨🥕

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change: adding `//#build` as a dependency for tsgo-based packages to fix a build race condition, which is the core objective of this PR.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix-turbo-tsc-deps

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

PR #2538 dropped `//#build` from `build.dependsOn`. `//#build` runs `tsc --build`, which produces composite-project `lib/` outputs that several workspace packages declare as their public types (`@lynx-js/rspeedy` → `./lib/index.d.ts`, etc.). `//#build` still runs as part of `pnpm turbo build` (no filter), but now in parallel with package builds. Two packages whose `tsgo` dts generation imports types from `lib/` race against `//#build`: - `@lynx-js/config-rsbuild-plugin` → imports `@lynx-js/rspeedy`, `@lynx-js/template-webpack-plugin` - `@lynx-js/reactlynx-testing-library` → imports `@lynx-js/rspeedy` When the race is lost, builds fail with `TS2307: Cannot find module …`. Add `//#build` to those two packages' own `dependsOn` (rather than the global `build.dependsOn`) so they wait for `tsc --build` without re-introducing the cache fanout #2538 was avoiding. Verified: `find packages -name "*.tsbuildinfo" -delete && find packages -type d -name lib -exec rm -rf {} + && pnpm turbo build --force` succeeds end-to-end (49/49 tasks).

codecov · 2026-04-29T13:00:35Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

codspeed-hq · 2026-04-29T13:05:28Z

Merging this PR will not alter performance

✅ 81 untouched benchmarks
⏩ 26 skipped benchmarks¹

_{Comparing fix-turbo-tsc-deps (80436e9) with main (caadd3b)²}

26 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on main (eb46fea) during the generation of this report, so caadd3b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

relativeci · 2026-04-29T13:07:35Z

React External

#838 Bundle Size — 680.41KiB (0%).

80436e9(current) vs 29ba9ba main#830(baseline)

Bundle metrics no changes

	Current #838	Baseline #830
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`0%`	`0%`
Chunks	`0`	`0`
Assets	`3`	`3`
Modules	`17`	`17`
Duplicate Modules	`5`	`5`
Duplicate Code	`8.59%`	`8.59%`
Packages	`0`	`0`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #838	Baseline #830
Other	`680.41KiB`	`680.41KiB`

Bundle analysis report Branch fix-turbo-tsc-deps Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2026-04-29T13:07:36Z

Web Explorer

#9296 Bundle Size — 900.03KiB (~+0.01%).

80436e9(current) vs 29ba9ba main#9288(baseline)

Bundle metrics

1 change

	Current #9296	Baseline #9288
Initial JS	`44.46KiB`	`44.46KiB`
Initial CSS	`2.22KiB`	`2.22KiB`
Cache Invalidation	`16.16%`	`0%`
Chunks	`9`	`9`
Assets	`11`	`11`
Modules	`229`	`229`
Duplicate Modules	`11`	`11`
Duplicate Code	`27.28%`	`27.28%`
Packages	`10`	`10`
Duplicate Packages	`0`	`0`

Bundle size by type

1 change

1 regression

	Current #9296	Baseline #9288
JS	`495.9KiB` (`~+0.01%`)	`495.88KiB`
Other	`401.92KiB`	`401.92KiB`
CSS	`2.22KiB`	`2.22KiB`

Bundle analysis report Branch fix-turbo-tsc-deps Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2026-04-29T13:07:37Z

React MTF Example

#855 Bundle Size — 196.58KiB (0%).

80436e9(current) vs 29ba9ba main#847(baseline)

Bundle metrics no changes

	Current #855	Baseline #847
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`0%`	`0%`
Chunks	`0`	`0`
Assets	`3`	`3`
Modules	`174`	`174`
Duplicate Modules	`66`	`66`
Duplicate Code	`44.04%`	`44.04%`
Packages	`2`	`2`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #855	Baseline #847
IMG	`111.23KiB`	`111.23KiB`
Other	`85.35KiB`	`85.35KiB`

Bundle analysis report Branch fix-turbo-tsc-deps Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2026-04-29T13:07:38Z

React Example

#7723 Bundle Size — 225.43KiB (0%).

80436e9(current) vs 29ba9ba main#7715(baseline)

Bundle metrics no changes

	Current #7723	Baseline #7715
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`0%`	`0%`
Chunks	`0`	`0`
Assets	`4`	`4`
Modules	`180`	`180`
Duplicate Modules	`69`	`69`
Duplicate Code	`44.54%`	`44.54%`
Packages	`2`	`2`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #7723	Baseline #7715
IMG	`145.76KiB`	`145.76KiB`
Other	`79.67KiB`	`79.67KiB`

Bundle analysis report Branch fix-turbo-tsc-deps Project dashboard

^{Generated by RelativeCI Documentation Report issue}

upupming force-pushed the fix-turbo-tsc-deps branch from e712dcc to 9358815 Compare April 29, 2026 12:30

upupming requested review from HuJean, Yradex, colinaaa, hzy and luhc228 as code owners April 29, 2026 12:30

upupming changed the title ~~fix(build): re-add //#build as dependency of build task~~ fix(build): make tsgo-dts packages depend on //#build Apr 29, 2026

coderabbitai Bot added the framework:React label Apr 29, 2026

fix(build): restore cached a2ui extractor outputs

dc1e01e

chore: drop unnecessary changeset

80436e9

colinaaa approved these changes Apr 30, 2026

View reviewed changes

HuJean approved these changes Apr 30, 2026

View reviewed changes

HuJean enabled auto-merge (squash) April 30, 2026 02:25

HuJean merged commit 3841ffe into main Apr 30, 2026
77 of 80 checks passed

HuJean deleted the fix-turbo-tsc-deps branch April 30, 2026 02:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(build): make tsgo-dts packages depend on `//#build`#2546

fix(build): make tsgo-dts packages depend on `//#build`#2546
HuJean merged 3 commits intomainfrom
fix-turbo-tsc-deps

upupming commented Apr 29, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

changeset-bot Bot commented Apr 29, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Apr 29, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

codecov Bot commented Apr 29, 2026 •

edited

Loading

Uh oh!

codspeed-hq Bot commented Apr 29, 2026 •

edited

Loading

Uh oh!

relativeci Bot commented Apr 29, 2026 •

edited

Loading

Uh oh!

relativeci Bot commented Apr 29, 2026 •

edited

Loading

Uh oh!

relativeci Bot commented Apr 29, 2026 •

edited

Loading

Uh oh!

relativeci Bot commented Apr 29, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

upupming commented Apr 29, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Fix

Test plan

Summary by CodeRabbit

Uh oh!

changeset-bot Bot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai Bot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

codecov Bot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codspeed-hq Bot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

relativeci Bot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

React External

#838 Bundle Size — 680.41KiB (0%).

Uh oh!

relativeci Bot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Web Explorer

#9296 Bundle Size — 900.03KiB (~+0.01%).

Uh oh!

relativeci Bot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

React MTF Example

#855 Bundle Size — 196.58KiB (0%).

Uh oh!

relativeci Bot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

React Example

#7723 Bundle Size — 225.43KiB (0%).

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

upupming commented Apr 29, 2026 •

edited by coderabbitai Bot

Loading

changeset-bot Bot commented Apr 29, 2026 •

edited

Loading

coderabbitai Bot commented Apr 29, 2026 •

edited

Loading

codecov Bot commented Apr 29, 2026 •

edited

Loading

codspeed-hq Bot commented Apr 29, 2026 •

edited

Loading

relativeci Bot commented Apr 29, 2026 •

edited

Loading

relativeci Bot commented Apr 29, 2026 •

edited

Loading

relativeci Bot commented Apr 29, 2026 •

edited

Loading

relativeci Bot commented Apr 29, 2026 •

edited

Loading