chore(react/transform): migrate from esbuild to Rslib by colinaaa · Pull Request #2239 · lynx-family/lynx-stack

colinaaa · 2026-02-13T07:52:03Z

Summary by CodeRabbit

Chores
- Switched WASM build to rslib, removed esbuild from dev dependencies, and updated wasm build inputs.
New Features
- Added a lightweight loader for importing WASM bytes.
Tests
- Simplified tests to assert normalized warning/error objects instead of formatted esbuild messages.

Checklist

Tests updated (or not required).
Documentation updated (or not required).
Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

chatgpt-codex-connector · 2026-02-13T07:52:08Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

changeset-bot · 2026-02-13T07:52:13Z

⚠️ No Changeset found

Latest commit: df45887

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-02-13T07:52:20Z

📝 Walkthrough

Walkthrough

Replace ad-hoc Node.js WASM build with an rslib/rsbuild configuration, add a buffer loader and rspack aliases, remove esbuild devDependency and legacy build script, adjust wasm import and build inputs, and update tests to assert raw warnings instead of using esbuild formatting.

Changes

Cohort / File(s)	Summary
Package manifest `packages/react/transform/package.json`	Replaced `build:wasm` command with `rslib build` and removed `esbuild` from devDependencies.
Rsbuild config `packages/react/transform/rslib.config.ts`	New rslib/rsbuild config: cargo build plugin for wasm, lib/output settings, wasm entry, rspack aliases/loader and module rule for `.wasm`.
Loader `packages/react/transform/scripts/buffer-loader.cjs`	Added CommonJS loader that returns `Buffer.from(base64, "base64")` and marks the loader as raw.
Removed legacy script `packages/react/transform/scripts/build_wasm.js`	Deleted previous Node.js build script that ran cargo and esbuild and copied wasm artifacts.
Build inputs `packages/react/transform/turbo.json`	Updated `build:wasm` inputs: removed `scripts/build_wasm.sh`, added `rslib.config.ts` and `scripts/buffer-loader.cjs`.
Source import `packages/react/transform/src/wasm.js`	Switched WASM import from `../dist/react_transform.wasm` to alias `#react_transform.wasm`.
Tests `packages/react/transform/__test__/*`	Removed runtime `esbuild` formatMessages usage; tests now assert `result.warnings`/`result.errors` or normalized warning objects directly.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

fix(deps): bump Rsbuild to 1.7.1 #2088 — Adds rslib/rsbuild usage and bumps rsbuild-related configuration referenced by the new rslib.config.ts.
fix(deps): bump Rsbuild 1.7.2 #2136 — Introduces rslib/rsbuild config and build command changes that align with this PR's build switch.
test(react/transform): fix snapshot #2160 — Touches packages/react/transform/__test__/fixture.spec.js and adjusts diagnostics/snapshot expectations similar to these test changes.

Suggested reviewers

gaoachao
upupming

Poem

🐇 I hopped from scripts into rslib's glen,
Cargo stitched bytes with a rustling pen,
A tiny loader wraps wasm in fur,
Tests now read warnings without the blur,
Carrots for build — let's hop again! 🥕

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Merge Conflict Detection	⚠️ Warning	❌ Merge conflicts detected (26 files): ⚔️ `benchmark/react/package.json` (content) ⚔️ `examples/motion/package.json` (content) ⚔️ `examples/react-compiler/package.json` (content) ⚔️ `examples/react-externals/package.json` (content) ⚔️ `examples/react-lazy-bundle/package.json` (content) ⚔️ `examples/react/package.json` (content) ⚔️ `examples/tailwindcss/package.json` (content) ⚔️ `package.json` (content) ⚔️ `packages/lynx/gesture-runtime/package.json` (content) ⚔️ `packages/motion/package.json` (content) ⚔️ `packages/react/package.json` (content) ⚔️ `packages/react/runtime/package.json` (content) ⚔️ `packages/react/transform/__test__/css/inline-style.spec.js` (content) ⚔️ `packages/react/transform/__test__/css/object-lit-style.spec.js` (content) ⚔️ `packages/react/transform/__test__/fixture.spec.js` (content) ⚔️ `packages/react/transform/package.json` (content) ⚔️ `packages/react/transform/src/wasm.js` (content) ⚔️ `packages/react/transform/turbo.json` (content) ⚔️ `packages/react/worklet-runtime/package.json` (content) ⚔️ `packages/rspeedy/core/package.json` (content) ⚔️ `packages/rspeedy/create-rspeedy/template-react-ts/package.json` (content) ⚔️ `packages/rspeedy/create-rspeedy/template-react-vitest-rltl-ts/package.json` (content) ⚔️ `packages/rspeedy/upgrade-rspeedy/package.json` (content) ⚔️ `packages/testing-library/examples/react-compiler/package.json` (content) ⚔️ `pnpm-lock.yaml` (content) ⚔️ `website/package.json` (content) These conflicts must be resolved before merging into `main`.	Resolve conflicts locally and push changes to this branch.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: migrating the react/transform package from esbuild to Rslib as the build tool.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

⚔️ Resolve merge conflicts (beta)

Auto-commit resolved conflicts to branch chore/migrate-esbuild-to-rslib
Post resolved changes as copyable diffs in a comment

No actionable comments were generated in the recent review. 🎉

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2026-02-13T07:55:17Z

Codecov Report

❌ Patch coverage is 0% with 85 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
packages/react/transform/rslib.config.ts	0.00%	76 Missing ⚠️
packages/react/transform/scripts/buffer-loader.cjs	0.00%	7 Missing ⚠️
packages/react/transform/src/wasm.js	0.00%	2 Missing ⚠️

📢 Thoughts on this report? Let us know!

coderabbitai

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@packages/react/transform/src/wasm.js`:
- Around line 7-9: The top-of-file build comment in wasm.js is stale: replace or
remove the line starting with "build with `./node_modules/.bin/esbuild ..." so
it no longer references the old esbuild command; either update it to the current
build instruction that uses "rslib build" or remove the comment entirely to
avoid confusion (the import line "import bytes from '#react_transform.wasm';"
and the file wasm.js are the anchors to locate the change).

🧹 Nitpick comments (2)

packages/react/transform/rslib.config.ts (2)
55-61: The WASM path traverses three directories up to the repo root — verify this holds in all build environments.

path.resolve(root, '../../../target/...') assumes the monorepo's target/ directory is exactly three levels above packages/react/transform. This is correct for the standard layout but could break if the package is ever moved or if cargo's target directory is overridden (e.g., via CARGO_TARGET_DIR).

Consider deriving the repo root dynamically (e.g., from a workspace root marker or git rev-parse --show-toplevel) instead of hard-coding the relative depth, or at minimum add a comment documenting this assumption.

10-27: Optional: Consider adding explicit type annotation for api parameter for consistency and clarity.

The satisfies RsbuildPlugin constraint provides structural type inference for the api parameter, but explicit annotation makes the intent clearer in strictest mode. The codebase shows mixed patterns—some setup methods use explicit RsbuildPluginAPI annotation (e.g., in test files), while others rely on satisfies inference. Adding an explicit type would align with the strictest TypeScript configuration.
💡 Suggested annotation
-  setup(api) {
+  setup(api: Parameters<RsbuildPlugin['setup']>[0]) {
Or use the exported RsbuildPluginAPI type directly if available from @rslib/core.

packages/react/transform/src/wasm.js

relativeci · 2026-02-13T08:10:23Z

Web Explorer

#7674 Bundle Size — 383.74KiB (0%).

df45887(current) vs 87682f6 main#7667(baseline)

Bundle metrics

1 change

	Current #7674	Baseline #7667
Initial JS	`154.88KiB`	`154.88KiB`
Initial CSS	`35.06KiB`	`35.06KiB`
Cache Invalidation	`0%`	`0%`
Chunks	`8`	`8`
Assets	`8`	`8`
Modules	`239`(`+0.84%`)	`237`
Duplicate Modules	`16`	`16`
Duplicate Code	`2.99%`	`2.99%`
Packages	`4`	`4`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #7674	Baseline #7667
JS	`252.83KiB`	`252.83KiB`
Other	`95.85KiB`	`95.85KiB`
CSS	`35.06KiB`	`35.06KiB`

Bundle analysis report Branch colinaaa:chore/migrate-esbuild-t... Project dashboard

^{Generated by RelativeCI Documentation Report issue}

codspeed-hq · 2026-02-14T03:08:01Z

Merging this PR will degrade performance by 6.07%

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 61 untouched benchmarks
⏩ 3 skipped benchmarks¹

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
⚡	`basic-performance-scroll-view-100`	11 ms	10.4 ms	+5.36%
❌	`basic-performance-div-10000`	456.6 ms	486.2 ms	-6.07%

_{Comparing colinaaa:chore/migrate-esbuild-to-rslib (df45887) with main (63a1cdb)²}

3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on main (87682f6) during the generation of this report, so 63a1cdb was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

chore(react/transform): migrate from esbuild to Rslib

869443b

colinaaa requested a review from gaoachao as a code owner February 13, 2026 07:52

coderabbitai bot added the framework:React label Feb 13, 2026

coderabbitai bot reviewed Feb 13, 2026

View reviewed changes

packages/react/transform/src/wasm.js Outdated Show resolved Hide resolved

Tweak comment

6c1a0e1

colinaaa added 2 commits February 13, 2026 16:33

test: remove esbuild

466c6f6

dprint fmt

df45887

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(react/transform): migrate from esbuild to Rslib#2239

chore(react/transform): migrate from esbuild to Rslib#2239
colinaaa wants to merge 4 commits intolynx-family:mainfrom
colinaaa:chore/migrate-esbuild-to-rslib

colinaaa commented Feb 13, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

chatgpt-codex-connector bot commented Feb 13, 2026

Uh oh!

changeset-bot bot commented Feb 13, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Feb 13, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

codecov bot commented Feb 13, 2026 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

relativeci bot commented Feb 13, 2026 •

edited

Loading

Uh oh!

codspeed-hq bot commented Feb 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

colinaaa commented Feb 13, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Checklist

Uh oh!

chatgpt-codex-connector bot commented Feb 13, 2026

Uh oh!

changeset-bot bot commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

codecov bot commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

relativeci bot commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Web Explorer

#7674 Bundle Size — 383.74KiB (0%).

Uh oh!

codspeed-hq bot commented Feb 14, 2026

Merging this PR will degrade performance by 6.07%

Performance Changes

Footnotes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

colinaaa commented Feb 13, 2026 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Feb 13, 2026 •

edited

Loading

coderabbitai bot commented Feb 13, 2026 •

edited

Loading

codecov bot commented Feb 13, 2026 •

edited

Loading

relativeci bot commented Feb 13, 2026 •

edited

Loading