Skip to content

test(react/transform): fix snapshot#2160

Merged
colinaaa merged 3 commits intolynx-family:mainfrom
colinaaa:colin/0130/transform-test
Jan 30, 2026
Merged

test(react/transform): fix snapshot#2160
colinaaa merged 3 commits intolynx-family:mainfrom
colinaaa:colin/0130/transform-test

Conversation

@colinaaa
Copy link
Copy Markdown
Collaborator

@colinaaa colinaaa commented Jan 30, 2026

Summary by CodeRabbit

  • Bug Fixes

    • Dynamic imports with no arguments no longer produce errors.
  • Chores

    • Updated build configuration formatting.

✏️ Tip: You can customize this high-level summary in your review settings.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).
  • Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

@colinaaa colinaaa requested a review from gaoachao as a code owner January 30, 2026 10:33
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jan 30, 2026

⚠️ No Changeset found

Latest commit: 9390b10

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jan 30, 2026

📝 Walkthrough

Walkthrough

This pull request removes test cases and error snapshots for dynamic import with no arguments from the fixture spec, and reformats the inputs arrays in two turbo.json configuration files from single-line to multi-line format while preserving their contents.

Changes

Cohort / File(s) Summary
Test adjustments
packages/react/transform/__test__/fixture.spec.js
Removed test cases and expected error snapshots for import() with no arguments; adjusted inline error snapshots and reindexed error lines accordingly.
Turbo configuration formatting
packages/react/transform/swc-plugin-reactlynx-compat/turbo.json, packages/react/transform/swc-plugin-reactlynx/turbo.json
Reformatted build task inputs arrays from single-line to multi-line format; all array entries remain unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • gaoachao
  • hzy

Poem

🐰 Test cases go, snapshots fade away,
Dynamic imports simplified today,
Turbo configs dressed in multi-line grace,
Clean and formatted, finding their place!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title refers to fixing snapshots in react/transform tests, which aligns with the primary change of removing dynamic import error test cases and adjusting snapshot expectations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

upupming
upupming previously approved these changes Jan 30, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@colinaaa colinaaa enabled auto-merge (squash) January 30, 2026 10:38
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Jan 30, 2026

CodSpeed Performance Report

Merging this PR will degrade performance by 5.15%

Comparing colinaaa:colin/0130/transform-test (9390b10) with main (3fe8949)

Summary

❌ 1 regressed benchmark
✅ 62 untouched benchmarks
⏩ 3 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
transform 1000 view elements 45 ms 47.4 ms -5.15%

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@relativeci
Copy link
Copy Markdown

relativeci bot commented Jan 30, 2026

Web Explorer

#7448 Bundle Size — 383.56KiB (0%).

9390b10(current) vs 3fe8949 main#7441(baseline)

Bundle metrics  Change 1 change
                 Current
#7448
     Baseline
#7441
No change  Initial JS 154.71KiB 154.71KiB
No change  Initial CSS 35.05KiB 35.05KiB
No change  Cache Invalidation 0% 0%
No change  Chunks 8 8
No change  Assets 8 8
Change  Modules 239(+0.84%) 237
No change  Duplicate Modules 16 16
No change  Duplicate Code 2.99% 2.99%
No change  Packages 4 4
No change  Duplicate Packages 0 0
Bundle size by type  no changes
                 Current
#7448
     Baseline
#7441
No change  JS 252.66KiB 252.66KiB
No change  Other 95.85KiB 95.85KiB
No change  CSS 35.05KiB 35.05KiB

Bundle analysis reportBranch colinaaa:colin/0130/transform-te...Project dashboard


Generated by RelativeCIDocumentationReport issue

@colinaaa colinaaa disabled auto-merge January 30, 2026 17:02
@colinaaa colinaaa merged commit af0abe8 into lynx-family:main Jan 30, 2026
45 of 46 checks passed
@colinaaa colinaaa deleted the colin/0130/transform-test branch January 30, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants