Skip to content

chore(react/transform): migrate from esbuild to Rslib #2239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
colinaaa wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore(react/transform): migrate from esbuild to Rslib #2239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
869443b
chore(react/transform): migrate from esbuild to Rslib
colinaaa Feb 13, 2026
6c1a0e1
Tweak comment
colinaaa Feb 13, 2026
466c6f6
test: remove esbuild
colinaaa Feb 13, 2026
df45887
dprint fmt
colinaaa Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 3 additions & 14 deletions packages/react/transform/__test__/css/inline-style.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,37 +7,28 @@ import { transformReactLynx } from '../../main.js';

describe('Parse Inline Style', () => {
it('should fallback to SetInlineStyles when have unknown CSS property', async () => {
const { formatMessages } = await import('esbuild');

const result = await transformReactLynx(
`<view style="height:100px;invalid:true;width: 200px"/>`,
);
// Should not have `__AddInlineStyle`
expect(result.code).not.toContain(`__AddInlineStyle`);
// Should have __SetInlineStyles(element, "height:100px;invalid:true;width: 200px")
expect(result.code).toContain('height:100px;invalid:true;width: 200px');
expect(
await formatMessages(result.warnings, { kind: 'warning', color: false }),
).toMatchInlineSnapshot(`[]`);
expect(result.warnings).toEqual([]);
});

it('should fallback to SetInlineStyles when parse CSS value failed', async () => {
const { formatMessages } = await import('esbuild');
const result = await transformReactLynx(
`<view style="height:100px;width: ; ;color: #0f0f0f"/>`,
);
// Should not have `__AddInlineStyle`
expect(result.code).not.toContain(`__AddInlineStyle`);
// Should have __SetInlineStyles(element, "height:100px;width: ; ;color: #0f0f0f")
expect(result.code).toContain('height:100px;width: ; ;color: #0f0f0f');
expect(
await formatMessages(result.warnings, { kind: 'warning', color: false }),
).toMatchInlineSnapshot(`[]`);
expect(result.warnings).toEqual([]);
});

it('should fallback to SetInlineStyles when parse CSS failed', async () => {
const { formatMessages } = await import('esbuild');

const result = await transformReactLynx(
`<view style="?*xxxxxxx;foo bar;"/>`,
);
Expand All @@ -46,8 +37,6 @@ describe('Parse Inline Style', () => {

// Should have __SetInlineStyles(element, "?*xxxxxxx;foo bar;")
expect(result.code).toContain('?*xxxxxxx;foo bar;');
expect(
await formatMessages(result.warnings, { kind: 'warning', color: false }),
).toMatchInlineSnapshot(`[]`);
expect(result.warnings).toEqual([]);
});
});
12 changes: 2 additions & 10 deletions packages/react/transform/__test__/css/object-lit-style.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,8 +258,6 @@ let jsx = <view style={{ height, width }}/>`,
});

it('should fallback to SetInlineStyles when have unknown CSS property', async () => {
const { formatMessages } = await import('esbuild');

const result = await transformReactLynx(
`<view style={{ width: '100px', invalid: false, height: '200rpx', invalidProperty: 'auto' }}/>`,
);
Expand All @@ -269,14 +267,10 @@ let jsx = <view style={{ height, width }}/>`,
expect(result.code).toContain(`width: '100px'`);
expect(result.code).toContain(`invalid: false`);
expect(result.code).toContain(`height: '200rpx'`);
expect(
await formatMessages(result.warnings, { kind: 'warning', color: false }),
).toMatchInlineSnapshot(`[]`);
expect(result.warnings).toEqual([]);
});

it('should fallback to SetInlineStyles when have computed CSS property', async () => {
const { formatMessages } = await import('esbuild');

const result = await transformReactLynx(
`<view style={{ width: value, [key]: false, height: '200rpx' }}/>`,
);
Expand All @@ -286,8 +280,6 @@ let jsx = <view style={{ height, width }}/>`,
expect(result.code).toContain(`width: value`);
expect(result.code).toContain(`[key]: false`);
expect(result.code).toContain(`height: '200rpx'`);
expect(
await formatMessages(result.warnings, { kind: 'warning', color: false }),
).toMatchInlineSnapshot(`[]`);
expect(result.warnings).toEqual([]);
});
});
Loading
Loading