[testnet] Revert transaction tracker refactoring#4502
Merged
ma2bd merged 5 commits intolinera-io:testnet_conwayfrom Sep 7, 2025
Merged
[testnet] Revert transaction tracker refactoring#4502ma2bd merged 5 commits intolinera-io:testnet_conwayfrom
ma2bd merged 5 commits intolinera-io:testnet_conwayfrom
Conversation
This reverts commit 642c6e7.
…nera-io#4471)" This reverts commit d8de840.
This reverts commit e06b356.
…roller. (linera-io#4413)" This reverts commit edad353.
This reverts commit 444aac8.
ma2bd
force-pushed
the
revert_tracker
branch
from
f6644b0 to
e5be68d
Compare
ma2bd
changed the title
afck
approved these changes
Sep 7, 2025
Contributor
afck
left a comment
afck
left a comment
There was a problem hiding this comment.
At a glance I can't find where the refactoring changed the semantics. I'll look into it this week.
afck
added a commit
to afck/linera-protocol
that referenced
this pull request
Sep 8, 2025
)" This reverts commit 99cca97.
afck
added a commit
that referenced
this pull request
Sep 8, 2025
## Motivation #4502 reverted a refactoring, because a bug was introduced: the behavior of `read_data_blob` was changed, and a duplicate oracle response was inserted. ## Proposal Restore the refactoring and fix the bug. ## Test Plan I ran the tests against Testnet Conway, and they pass now. ## Release Plan - Nothing to do / These changes follow the usual release cycle. ## Links - Original refactoring: #4413 - Revert PR: #4502 - Fix on main branch: #4510. - [reviewer checklist](https://github.com/linera-io/linera-protocol/blob/main/CONTRIBUTING.md#reviewer-checklist)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Make sure remote tests pass against the current testnet
Proposal
Revert the portage of #4471 and (sadly) a number of commits that depend on it.
Test Plan
CI + run remote tests
See also #4503
Release Plan
on testnet branch