Make transaction tracker oracle methods harder to misuse.#4471
Merged
afck merged 1 commit intolinera-io:mainfrom Sep 3, 2025
Merged
Make transaction tracker oracle methods harder to misuse.#4471afck merged 1 commit intolinera-io:mainfrom
afck merged 1 commit intolinera-io:mainfrom
Conversation
deuszx
approved these changes
Sep 3, 2025
Contributor
deuszx
left a comment
deuszx
left a comment
There was a problem hiding this comment.
Yeah, this looks much better :)
afck
added a commit
to afck/linera-protocol
that referenced
this pull request
Sep 4, 2025
…4471) ## Motivation In the execution code, oracles must always be used as follows: * In replay mode, we consume an oracle response from the recorded ones. * If _not_ in replay mode, we query the actual oracle to obtain the value. * In both cases, we have to add it to the oracle responses in the execution outcome. It's currently easy to forget one of those steps. ## Proposal Refactor the transaction tracker's methods to make it a bit harder to use them the wrong way. ## Test Plan CI ## Release Plan - Nothing to do / These changes follow the usual release cycle. - (But could easily be backported.) ## Links - Closes linera-io#3519. - [reviewer checklist](https://github.com/linera-io/linera-protocol/blob/main/CONTRIBUTING.md#reviewer-checklist)
Closed
ma2bd
pushed a commit
that referenced
this pull request
Sep 5, 2025
## Motivation In the execution code, oracles must always be used as follows: * In replay mode, we consume an oracle response from the recorded ones. * If _not_ in replay mode, we query the actual oracle to obtain the value. * In both cases, we have to add it to the oracle responses in the execution outcome. It's currently easy to forget one of those steps. ## Proposal Refactor the transaction tracker's methods to make it a bit harder to use them the wrong way. ## Test Plan CI ## Release Plan - Nothing to do / These changes follow the usual release cycle. - (But could easily be backported.) ## Links - Closes #3519. - [reviewer checklist](https://github.com/linera-io/linera-protocol/blob/main/CONTRIBUTING.md#reviewer-checklist)
ma2bd
pushed a commit
that referenced
this pull request
Sep 5, 2025
## Motivation In the execution code, oracles must always be used as follows: * In replay mode, we consume an oracle response from the recorded ones. * If _not_ in replay mode, we query the actual oracle to obtain the value. * In both cases, we have to add it to the oracle responses in the execution outcome. It's currently easy to forget one of those steps. ## Proposal Refactor the transaction tracker's methods to make it a bit harder to use them the wrong way. ## Test Plan CI ## Release Plan - Nothing to do / These changes follow the usual release cycle. - (But could easily be backported.) ## Links - Closes #3519. - [reviewer checklist](https://github.com/linera-io/linera-protocol/blob/main/CONTRIBUTING.md#reviewer-checklist)
ma2bd
added a commit
to ma2bd/linera-protocol
that referenced
this pull request
Sep 6, 2025
…nera-io#4471)" This reverts commit d8de840.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In the execution code, oracles must always be used as follows:
It's currently easy to forget one of those steps.
Proposal
Refactor the transaction tracker's methods to make it a bit harder to use them the wrong way.
Test Plan
CI
Release Plan
Links
next_replayed_oracle_responsesafer to use. #3519.