Restore old behavior: Don't record oracle if blob known from same block.#4510
Merged
afck merged 3 commits intolinera-io:mainfrom Sep 8, 2025
Merged
Restore old behavior: Don't record oracle if blob known from same block.#4510afck merged 3 commits intolinera-io:mainfrom
afck merged 3 commits intolinera-io:mainfrom
Conversation
deuszx
approved these changes
Sep 8, 2025
Contributor
|
@afck How hard is it to cover this behavior with a unit test? |
Contributor
Author
|
I'll try to extend a test to check for this regression. I just noticed that the test that originally uncovered the problem was removed in #4397, and replaced by a client test (which we wouldn't run against the network). (My bad: I suggested replacing more tests with client tests.) |
Contributor
Author
|
Extended the test in 3407f6d. |
afck
added a commit
that referenced
this pull request
Sep 8, 2025
## Motivation #4502 reverted a refactoring, because a bug was introduced: the behavior of `read_data_blob` was changed, and a duplicate oracle response was inserted. ## Proposal Restore the refactoring and fix the bug. ## Test Plan I ran the tests against Testnet Conway, and they pass now. ## Release Plan - Nothing to do / These changes follow the usual release cycle. ## Links - Original refactoring: #4413 - Revert PR: #4502 - Fix on main branch: #4510. - [reviewer checklist](https://github.com/linera-io/linera-protocol/blob/main/CONTRIBUTING.md#reviewer-checklist)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#4413 introduced a bug where we record redundant oracle responses:
blob_useditself already records the response, so there is no need to callreplay_oracle_response.Proposal
Restore the old behavior.
Test Plan
This caused the remote tests against Testnet Conway to break, and with this fix on the
testnet_conwaybranch, they work again.Release Plan
Links