Remove some unused code, annotations.#4476
Merged
afck merged 1 commit intolinera-io:mainfrom Sep 4, 2025
Merged
Conversation
bart-linera
approved these changes
Sep 4, 2025
afck
added a commit
to afck/linera-protocol
that referenced
this pull request
Sep 4, 2025
## Motivation In `test_utils` we `#![allow(unused_imports)]` because "items are only used by some tests" and "Rust will complain". That doesn't seem to be true, and if it were I don't see why the affected test shouldn't just import the items in question directly. ## Proposal Remove the attribute and the unused imports. Also, remove or restrict some similar attributes in other places. ## Test Plan CI ## Release Plan - Nothing to do / These changes follow the usual release cycle. ## Links - [reviewer checklist](https://github.com/linera-io/linera-protocol/blob/main/CONTRIBUTING.md#reviewer-checklist)
afck
added a commit
to afck/linera-protocol
that referenced
this pull request
Sep 4, 2025
## Motivation In `test_utils` we `#![allow(unused_imports)]` because "items are only used by some tests" and "Rust will complain". That doesn't seem to be true, and if it were I don't see why the affected test shouldn't just import the items in question directly. ## Proposal Remove the attribute and the unused imports. Also, remove or restrict some similar attributes in other places. ## Test Plan CI ## Release Plan - Nothing to do / These changes follow the usual release cycle. ## Links - [reviewer checklist](https://github.com/linera-io/linera-protocol/blob/main/CONTRIBUTING.md#reviewer-checklist)
Closed
ma2bd
pushed a commit
that referenced
this pull request
Sep 5, 2025
## Motivation In `test_utils` we `#![allow(unused_imports)]` because "items are only used by some tests" and "Rust will complain". That doesn't seem to be true, and if it were I don't see why the affected test shouldn't just import the items in question directly. ## Proposal Remove the attribute and the unused imports. Also, remove or restrict some similar attributes in other places. ## Test Plan CI ## Release Plan - Nothing to do / These changes follow the usual release cycle. ## Links - [reviewer checklist](https://github.com/linera-io/linera-protocol/blob/main/CONTRIBUTING.md#reviewer-checklist)
ma2bd
pushed a commit
that referenced
this pull request
Sep 5, 2025
## Motivation In `test_utils` we `#![allow(unused_imports)]` because "items are only used by some tests" and "Rust will complain". That doesn't seem to be true, and if it were I don't see why the affected test shouldn't just import the items in question directly. ## Proposal Remove the attribute and the unused imports. Also, remove or restrict some similar attributes in other places. ## Test Plan CI ## Release Plan - Nothing to do / These changes follow the usual release cycle. ## Links - [reviewer checklist](https://github.com/linera-io/linera-protocol/blob/main/CONTRIBUTING.md#reviewer-checklist)
ma2bd
added a commit
to ma2bd/linera-protocol
that referenced
this pull request
Sep 6, 2025
This reverts commit 642c6e7.
ma2bd
added a commit
to ma2bd/linera-protocol
that referenced
this pull request
Sep 6, 2025
This reverts commit 444aac8.
ma2bd
added a commit
to ma2bd/linera-protocol
that referenced
this pull request
Sep 6, 2025
This reverts commit 444aac8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In
test_utilswe#![allow(unused_imports)]because "items are only used by some tests" and "Rust will complain". That doesn't seem to be true, and if it were I don't see why the affected test shouldn't just import the items in question directly.Proposal
Remove the attribute and the unused imports.
Also, remove or restrict some similar attributes in other places.
Test Plan
CI
Release Plan
Links