Repository navigation
Conversation
Aionw
requested review from
Ann-1024,
ShangmingCai,
UNIDY2002,
alogfans,
luketong777,
staryxchen,
stmatengss,
ykwd and
zxpdemonio
as code owners
August 24, 2026 08:46
Icedcoco
approved these changes
Sep 18, 2026
Icedcoco
left a comment
Collaborator
There was a problem hiding this comment.
LGTM
This is a behavior-preserving Phase 2 source migration. The missing PEP 517 CI coverage is planned for the later RFC build/release work, and the isolated-wheel aiohttp check is covered by #3632, which is expected to land around the same time. These are transition gaps rather than blockers for this PR.
ykwd
approved these changes
Oct 14, 2026
Keep both sides where main migrated structured_object_store.py and _fast_copy.c alongside the Store REST service in CODEOWNERS, labeler.yml, the build_wheel.sh migrated-module list and test_project.py.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements one Phase 2 module migration from RFC #3534:
python/mooncake/mooncake_store_service.pysource root;python/tests/storeand removes both old tracked locations;mooncake.mooncake_store_serviceimport andmc_store_rest_servercommand;This is part of #3534 and does not perform any Phase 3 native-extension rename or Phase 4/5 release cutover.
Overlap with open work
mooncake_config.py; this PR deliberately leaves that module at the location onmainand keeps the existingfrom mooncake.mooncake_config import MooncakeConfigcontract. The PRs touch the same CMake install block, wheel staging script, packaging tests, CODEOWNERS, and labeler configuration, but migrate distinct files.scripts/build_wheel.sh, packaging checks, ownership, and labels. None owns the Store REST service implementation or tests.Module
mooncake-transfer-engine)mooncake-store)mooncake-reshard)mooncake-ep)mooncake-pg)mooncake-integration)mooncake-p2p-store)mooncake-wheel)mooncake-common)mooncake-rl)Type of Change
How Has This Been Tested?
Test commands:
python -m pytest -q python/tests/store/test_mooncake_store_service_api.py python/tests/packaging/test_project.py python -m pytest -q python/tests/packaging CMAKE_BUILD_PARALLEL_LEVEL=128 python -m build --wheel --outdir /tmp/mooncake-store-service-dist MOONCAKE_TEST_WHEEL=/tmp/mooncake-store-service-dist/mooncake_transfer_engine-0.3.12.post1-cp310-cp310-linux_x86_64.whl python -m pytest -q python/tests/packaging/test_installed_wheel.py python -m twine check /tmp/mooncake-store-service-dist/mooncake_transfer_engine-0.3.12.post1-cp310-cp310-linux_x86_64.whl python -m compileall -q python/mooncake/mooncake_store_service.py python/tests/store/test_mooncake_store_service_api.py python/tests/packaging/test_project.py python/tests/packaging/test_installed_wheel.py bash -n scripts/build_wheel.sh scripts/test_installation.sh pre-commit run --files $(git diff --name-only --diff-filter=ACMR origin/main...HEAD)Test results:
mc_store_rest_serverentry-point load succeed outside the repository)mooncake/mooncake_store_service.py, omits legacy/test paths, andtwine checkpasses)Documentation validation gap:
make htmlcould not run because Sphinx is absent. The documenteduvexecutable is blocked by snap confinement in this container, while the pip fallback expands into the multi-gigabyte Torch/CUDA documentation dependency set. The changed Markdown passesgit diff --check, trailing-whitespace, EOF, codespell, and the other PR-scoped pre-commit hooks.Checklist
./scripts/code_format.sh(no C/C++ source changes; Python and CMake formatting passed through pre-commit)AI Assistance Disclosure
OpenAI Codex assisted with repository analysis, the scoped migration, test maintenance, packaging/build validation, and PR preparation. The human submitter remains responsible for reviewing, understanding, and defending every changed line.