Repository navigation
[Store] Migrate async Python client to unified package - #3624
Merged
Merged
Conversation
Aionw
requested review from
Ann-1024,
luketong777,
stmatengss,
ykwd and
zxpdemonio
as code owners
August 24, 2026 08:38
15 of 31 tasks
Icedcoco
approved these changes
Sep 17, 2026
Icedcoco
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. The migration preserves the public import path and wrapper behavior, and the build and integration-test paths are updated consistently.
One non-blocking question: would it make sense to wire the new unit and packaging tests into CI here, or would you prefer to handle that as part of the broader packaging migration?
Collaborator
Author
|
When our release pipeline migrate to scikit-build-core, those test will be
handled all at once.
Icedcoco ***@***.***> 于2026年9月17日周四 16:26写道:
… ***@***.**** approved this pull request.
LGTM. The migration preserves the public import path and wrapper behavior,
and the build and integration-test paths are updated consistently.
One non-blocking question: would it make sense to wire the new unit and
packaging tests into CI here, or would you prefer to handle that as part of
the broader packaging migration?
—
Reply to this email directly, view it on GitHub
<#3624?email_source=notifications&email_token=AJ3VZW62KHJD52K7ECZQPHL5PON2DA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMRTGMYDENJVGEY2M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#pullrequestreview-5233025511>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJ3VZW2UXY55LZ6NDXXTR6D5PON2DAVCNFSNUABFKJSXA33TNF2G64TZHM4DCOJXGMZTCNZTHNEXG43VMU5TKMRTGI3TINZVGI2KC5QC>
.
You are receiving this because you authored the thread.Message ID:
<kvcache-ai/Mooncake/pull/3624/review/5233025511 ***@***.***
.com>
|
ykwd
approved these changes
Sep 18, 2026
This was referenced Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements the async Store Python client slice of RFC #3534 Phase 2.
mooncake-integration/store/async_store.pyto the canonicalpython/mooncake/async_store.pypackage source and removes the old tracked location.python/tests/store/async_store_integration.py, updates its CI invocation, and adds mocked source-import and behavior tests that need no Store cluster.mooncake.async_store.MooncakeDistributedStoreAsyncimport and behavior. This does not rename the native Store extension, create the final Store facade, or migrate structured Store/services/config/buffer-pool code.Overlap
async_store.pyand its directly owned tests, so the module changes are complementary even though a later rebase may be needed.mooncake.async_store; this PR intentionally preserves current wrapper behavior.mainto relocate. The shared Python pyright configuration is separately owned by [Reshard] Migrate to unified Python package #3585 and is not duplicated here.Module
mooncake-transfer-engine)mooncake-store)mooncake-reshard)mooncake-ep)mooncake-pg)mooncake-integration)mooncake-p2p-store)mooncake-wheel)mooncake-common)mooncake-rl)Type of Change
How Has This Been Tested?
Test commands:
Test results:
twine checkpassed, and the wheel smoke test installed with--no-depsin a clean venv outside the repository.Checklist
./scripts/code_format.sh(not applicable: no C/C++ files changed; all relevant pre-commit format hooks passed)AI Assistance Disclosure
OpenAI Codex performed the scoped migration, updated build/packaging metadata, added tests, and ran the reported validation. The human submitter remains responsible for reviewing and defending every changed line.