Repository navigation
[Store] Migrate lightweight Python utilities to unified package - #3586
Merged
Merged
Conversation
Aionw
force-pushed
the
codex/migrate-python-utilities
branch
from
August 21, 2026 16:47
b0a86b3 to
c86f8c4
Compare
Aionw
force-pushed
the
codex/migrate-python-utilities
branch
from
August 24, 2026 07:59
c86f8c4 to
f0a0016
Compare
Aionw
marked this pull request as ready for review
August 24, 2026 08:24
Aionw
requested review from
Ann-1024,
ShangmingCai,
luketong777,
stmatengss,
ykwd and
zxpdemonio
as code owners
August 24, 2026 08:24
This was referenced Aug 24, 2026
…utilities # Conflicts: # .github/CODEOWNERS # python/tests/packaging/test_installed_wheel.py # python/tests/packaging/test_project.py # scripts/build_wheel.sh
Aionw
force-pushed
the
codex/migrate-python-utilities
branch
from
September 8, 2026 08:12
f0a0016 to
f07bd07
Compare
Collaborator
|
Could you please confirm whether the direct CMake installation path also needs to install buffer_pool.py? Since the module was moved from mooncake-wheel/mooncake to python/mooncake, the install(DIRECTORY ...) rule in python/CMakeLists.txt will no longer include it. However, mooncake/init.py still imports mooncake.buffer_pool, so users installing through the direct CMake path may encounter ModuleNotFoundError. The wheel staging path appears to handle this module correctly. Would it make sense to add buffer_pool.py to the direct CMake install list and include a corresponding installation test? |
ykwd
approved these changes
Sep 17, 2026
ShangmingCai
approved these changes
Sep 17, 2026
ShangmingCai
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, just some harmless test file migration and clean up.
DHX98
added a commit
to DHX98/Mooncake
that referenced
this pull request
Sep 23, 2026
Adapt to upstream changes since the PR opened: - MasterService header split (kvcache-ai#4127): PromotionTask::from_prefetch moves to object_runtime_state.h; friend list follows the MasterServiceTestPeer form (kvcache-ai#4135) plus PrefetchTaskMasterTest. - probeKey/BatchProbeKey RPCs (kvcache-ai#3801) coexist with ExistOptions. - Python unified-package layout (kvcache-ai#3586): keep buffer_pool.py at its pre-existing path; migration is a separate follow-up.
DHX98
added a commit
to DHX98/Mooncake
that referenced
this pull request
Sep 28, 2026
Adapt to upstream changes since the PR opened: - MasterService header split (kvcache-ai#4127): PromotionTask::from_prefetch moves to object_runtime_state.h; friend list follows the MasterServiceTestPeer form (kvcache-ai#4135), plus PrefetchTaskMasterTest. - probeKey/BatchProbeKey RPCs (kvcache-ai#3801) coexist with ExistOptions. - Python unified-package layout (kvcache-ai#3586): keep buffer_pool.py at its pre-existing path; migration is a separate follow-up. - Design doc moved to docs/source/design/store/ssd-prefetch.md per the kvcache-ai#4196 module-grouped layout; drop stale toctree entries for moved docs.
10 tasks done
Aionw
added a commit
that referenced
this pull request
Sep 28, 2026
main's /python/tests/store/ entry (#3586) would otherwise drop @zxpdemonio from the two migrated structured-object tests. Place the per-file entries after it so they take effect.
Aionw
added a commit
that referenced
this pull request
Oct 14, 2026
* [Wheel] Migrate structured object storage to unified package * [Wheel] Format migrated structured object store sources and keep legacy test fallback The migrated files count as fully changed for the changed-lines ruff check, so format them with ruff 0.6.9 (the result equals ruff format of main's legacy-path copies). Let mooncake-wheel/tests/conftest.py extend mooncake.__path__ for both the unified source package and the legacy tree, so legacy-only helpers such as mooncake._partial_read stay importable from source. * [Wheel] Keep structured-object test owners after merging main main's /python/tests/store/ entry (#3586) would otherwise drop @zxpdemonio from the two migrated structured-object tests. Place the per-file entries after it so they take effect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements another Phase 2 increment from #3534 by moving lightweight Store-facing Python utilities into the unified root Python package.
mooncake.buffer_poolandmooncake.mooncake_configintopython/mooncakeas their single authoritative source;python/tests;This migration is independent of #3585. The branch is based directly on
mainand contains no Reshard migration changes.Module
mooncake-transfer-engine)mooncake-store)mooncake-reshard)mooncake-ep)mooncake-pg)mooncake-integration)mooncake-p2p-store)mooncake-wheel)mooncake-common)mooncake-rl)Type of Change
How Has This Been Tested?
Test commands:
Test results:
twine checkpasses)Checklist
./scripts/code_format.sh(no C/C++ source changes; Python and CMake formatting passed through pre-commit)AI Assistance Disclosure
OpenAI Codex assisted with migration selection, implementation, packaging validation, and PR preparation. The human submitter remains responsible for reviewing and defending every changed line.