Repository navigation
Conversation
Aionw
requested review from
Ann-1024,
luketong777,
stmatengss and
ykwd
as code owners
August 24, 2026 08:41
15 of 31 tasks
16 of 20 tasks
Conflict resolution (all same-spot appends; both sides kept): - .github/CODEOWNERS: kept the allocator owner entries and main's http_metadata_server/async_store/buffer_pool entries, allocator lines first after the ha/ entry, matching how siblings were inserted. - python/tests/packaging/test_installed_wheel.py: kept the fabric_allocator_utils import alongside main's http_metadata_server and mooncake_config imports (alphabetical), and kept main's simple KVBootstrapServer/MooncakeConfig asserts followed by the allocator wheel-location and fake-torch import checks. - python/tests/packaging/test_project.py: kept ALLOCATOR_MODULES next to main's CLI_MODULES/CLI_ENTRY_POINTS, and kept the allocator source/build input tests ahead of main's http_metadata_server and async_store tests. scripts/build_wheel.sh, mooncake-integration/CMakeLists.txt, python/CMakeLists.txt and .github/labeler.yml merged cleanly.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements the allocator subsystem portion of Phase 2 in #3534.
mooncake.allocator,mooncake.allocator_ascend_npu, andmooncake.fabric_allocator_utilsintopython/mooncakeas their sole tracked source;scripts/build_wheel.shstaging path;Overlap check: Since this PR was opened, #3586, #3624, #3626, #3630, #3632, and #3635 have landed on
main; this branch includes them through itsmainsyncs, most recently the 2026-09-28 merge ofmain(d9152a4). #3585 (Reshard) is still open and remains out of scope. #2404 (now merged) and #3396 (still open) change unsupported allocator protocol handling in the native Transfer Engine binding; they do not move or modify these Python allocator implementations. #2305 (open) adds a logging hook to the legacymooncake-integration/allocator.py; if it lands, that change must move topython/mooncake/allocator.py.Module
mooncake-transfer-engine)mooncake-store)mooncake-reshard)mooncake-ep)mooncake-pg)mooncake-integration)mooncake-p2p-store)mooncake-wheel)mooncake-common)mooncake-rl)Type of Change
How Has This Been Tested?
Original submission (before merging
mainon 2026-09-28; superseded by "After mergingmain" below):Test commands:
Test results:
twine check, and isolated--no-depswheel install/import outside the repository)torchortorch_npu; installed hardware modules imported with synthetic runtimes)After merging
main(d9152a4, 2026-09-28):PYTHONPATH=python:mooncake-wheel python -m pytest -q python/tests/allocators python/tests/packaging pre-commit run --files $(git diff --name-only --diff-filter=ACMR origin/main...HEAD)MOONCAKE_TEST_WHEEL/MOONCAKE_TEST_LEGACY_WHEEL..github/CODEOWNERS,python/tests/packaging/test_installed_wheel.py,python/tests/packaging/test_project.pywere resolved by keeping both sides.ruff checkplusscripts/ci/check_changed_python_format.py, ruff 0.6.9) passes.cmake-format, which only rewrites thetent_metricsblock inmooncake-integration/CMakeLists.txtinherited frommain;mainat d9152a4 fails the same way, and this PR's own CMake lines pass.twine check, and installed-wheel smoke runs from the original submission were not repeated after the merge. CI does not run them either (it builds only the legacyscripts/build_wheel.shwheel and runsscripts/test_installation.sh), so they still need a rerun.Checklist
./scripts/code_format.sh(no C/C++ source changes; PR-scoped pre-commit formatting passed)main, except the pre-existingcmake-formatissue noted under "After mergingmain")AI Assistance Disclosure
OpenAI Codex assisted with repository and overlap analysis, the module migration, packaging/build updates, test authoring, validation, and PR preparation. The human submitter remains responsible for reviewing every changed line and understanding and defending the change end to end.
Claude Code (Anthropic) merged
maininto this branch on 2026-09-28, resolved the conflicts, re-ran the focused tests listed under "After mergingmain", and updated this description.