🐛 [release-0.7] uplift go and x/net#1486
Merged
k8s-ci-robot merged 3 commits intokubernetes-sigs:release-0.7from Feb 22, 2023
Merged
🐛 [release-0.7] uplift go and x/net#1486k8s-ci-robot merged 3 commits intokubernetes-sigs:release-0.7from
k8s-ci-robot merged 3 commits intokubernetes-sigs:release-0.7from
Conversation
Works round some go mod dependency issues upgrading to v1.51.1, and is in line with what CAPI does.
While there, remove some legacy skipped paths and rename skipped_dirs to reflect that it actually skips paths (including ensure-golangci-lint.sh, which is a file, not a directory).
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
k8s-ci-robot
added
cncf-cla: yes
Contributor
Author
|
Ok now it found the same linting issue that suddenly appeared #1460. Fixing... |
Uplift golang to 1.19.6 and x/net to 0.7.0 due https://osv.dev/vulnerability/GO-2023-1571
lentzi90
force-pushed
the
lentzi90/backport-security-fixes-release-0.7
branch
from
1853701 to
f4593b2
Compare
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
mdbooth
approved these changes
Feb 22, 2023
| } | ||
|
|
||
| for _, tt := range tests { | ||
| tt := tt |
Contributor
There was a problem hiding this comment.
This is fine, but backporting a PR which changes api/ is surprising.
It would be good to move most code out of api which isn't type definitions at some point.
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90, mdbooth The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Backport of #1482 and #1470