Skip to content

[release-0.7] 🐛 Fix Provisioning to Unavailable AZs#1488

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:release-0.7from
k8s-infra-cherrypick-robot:cherry-pick-1479-to-release-0.7
Feb 23, 2023
Merged

[release-0.7] 🐛 Fix Provisioning to Unavailable AZs#1488
k8s-ci-robot merged 1 commit intokubernetes-sigs:release-0.7from
k8s-infra-cherrypick-robot:cherry-pick-1479-to-release-0.7

Conversation

@k8s-infra-cherrypick-robot
Copy link

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot commented Feb 22, 2023

This is an automated cherry-pick of #1479

/assign mdbooth

@spjmurray
Fix Provisioning to Unavailable AZs
0a31fdc 
CAPO uses any ZA it finds, rather than checking whether the ZA is
actually available, meaning you can get into a state where it's
impossible to provision a cluster.  This allows clients to filter based
on AZ availability before scheduling.
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Feb 22, 2023
Merged
2 tasks
@netlify
Copy link

netlify bot commented Feb 22, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 0a31fdc
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/63f5ee545d71ca00072337ca
😎 Deploy Preview https://deploy-preview-1488--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 22, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 22, 2023
lentzi90
lentzi90 reviewed Feb 22, 2023
View reviewed changes
Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2023
@lentzi90
Copy link
Contributor

lentzi90 commented Feb 22, 2023

Failing because of the golang-ci-lint issue that was fixed on main already but not backported yet. There is a PR for the backport here: #1486

@lentzi90
Copy link
Contributor

lentzi90 commented Feb 22, 2023

/test pull-cluster-api-provider-openstack-test

@lentzi90
Copy link
Contributor

lentzi90 commented Feb 22, 2023

/test pull-cluster-api-provider-openstack-e2e-full-test

@mdbooth
Copy link
Contributor

mdbooth commented Feb 22, 2023

/hold

Pending full-test

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2023
@lentzi90
Copy link
Contributor

lentzi90 commented Feb 22, 2023

Devstack failed to come up. Re-running.
/test pull-cluster-api-provider-openstack-e2e-full-test

@jichenjc
Copy link
Contributor

jichenjc commented Feb 22, 2023

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2023
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc, k8s-infra-cherrypick-robot, mnaser

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lentzi90
Copy link
Contributor

lentzi90 commented Feb 23, 2023

Full test passed and looks good.
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit c61ea15 into kubernetes-sigs:release-0.7 Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@jichenjc jichenjc Awaiting requested review from jichenjc

+1 more reviewer

@mnaser mnaser mnaser approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mdbooth mdbooth

@lentzi90 lentzi90

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@k8s-infra-cherrypick-robot @lentzi90 @mdbooth @jichenjc @k8s-ci-robot @mnaser @spjmurray