Skip to content

Download golangci-lint instead of building it #1470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 2 commits into from
Feb 9, 2023
Merged

Download golangci-lint instead of building it #1470

k8s-ci-robot merged 2 commits into from
Feb 9, 2023

Conversation

@mdbooth
Copy link
Contributor

@mdbooth mdbooth commented Feb 9, 2023

Works round some go mod dependency issues upgrading to v1.51.1, and is in line with what CAPI does.

Fixes #1469

@mdbooth
Download golangci-lint instead of building it
451c881 
Works round some go mod dependency issues upgrading to v1.51.1, and is
in line with what CAPI does.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 9, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2023
@netlify
Copy link

netlify bot commented Feb 9, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 77ec942
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/63e50f415f93a10008c85e5c
😎 Deploy Preview https://deploy-preview-1470--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 9, 2023
@tobiasgiese
Copy link
Member

tobiasgiese commented Feb 9, 2023

/approve
/lgtm

Thanks for fixing this! 💯

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2023
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth, tobiasgiese

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [mdbooth,tobiasgiese]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mdbooth mdbooth mentioned this pull request Feb 9, 2023
Closed
@mdbooth
Update verify-boilerplate.sh to ignore ensure-golangci-lint.sh
77ec942 
While there, remove some legacy skipped paths and rename skipped_dirs to
reflect that it actually skips paths (including ensure-golangci-lint.sh,
which is a file, not a directory).
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2023
@tobiasgiese
Copy link
Member

tobiasgiese commented Feb 9, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2023
@mdbooth
Copy link
Contributor Author

mdbooth commented Feb 9, 2023

Test failure was due to verify-boilerplate: I hadn't added a copyright notice to ensure-golang-lint.sh. I notice that CAPI have added the copyright notice, but as noted in that file: it's downloaded from another project. Even then it's auto generated with a third project. I'm not 100% sure what the copyright on it is, but I'm pretty sure it's not ours.

I made a small change to boilerplate.py to skip it.

@k8s-ci-robot k8s-ci-robot merged commit 595ab94 into kubernetes-sigs:main Feb 9, 2023
@mdbooth mdbooth deleted the golangci-lint branch February 9, 2023 17:18
@mdbooth mdbooth mentioned this pull request Feb 15, 2023
Merged
@lentzi90 lentzi90 mentioned this pull request Feb 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lentzi90 lentzi90 Awaiting requested review from lentzi90

@tobiasgiese tobiasgiese Awaiting requested review from tobiasgiese

Assignees

@tobiasgiese tobiasgiese

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

make lint failing with OOM recently

3 participants

@mdbooth @tobiasgiese @k8s-ci-robot