Skip to content

Conversation

@tuminoid
Copy link
Contributor

Uplift golang to 1.19.6 and x/net to 0.7.0 due https://osv.dev/vulnerability/GO-2023-1571

@netlify
Copy link

netlify bot commented Feb 17, 2023

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit af972a5
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/63ef7c2a954df90008b3772f
😎 Deploy Preview https://deploy-preview-1482--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 17, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @tuminoid. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 17, 2023
@lentzi90
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 17, 2023
@tuminoid tuminoid changed the title 🐛 uplift go and x/net 🐛 uplift golang and x/net Feb 17, 2023
@mdbooth
Copy link
Contributor

mdbooth commented Feb 17, 2023

/ok-to-test

Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Could you bump golang also in the {Docker|Container}file?

FROM golang:1.19.3 as builder

FROM golang:1.19.3 as builder

Uplift golang to 1.19.6 and x/net to 0.7.0 due
https://osv.dev/vulnerability/GO-2023-1571
@tuminoid tuminoid force-pushed the tuomo/uplift-go-and-x-net branch from 5fed53c to af972a5 Compare February 17, 2023 13:07
@tuminoid
Copy link
Contributor Author

Good catch @lentzi90. Bumped those too.

@mdbooth
Copy link
Contributor

mdbooth commented Feb 17, 2023

Thanks. Tests pending, obviously:

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth, tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2023
Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2023
@lentzi90
Copy link
Contributor

/cherry-pick release-0.7

@k8s-infra-cherrypick-robot

@lentzi90: once the present PR merges, I will cherry-pick it on top of release-0.7 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-0.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit ff4c1de into kubernetes-sigs:main Feb 17, 2023
@k8s-infra-cherrypick-robot

@lentzi90: #1482 failed to apply on top of branch "release-0.7":

Applying: uplift go and x/net
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
M	hack/tools/go.mod
M	hack/tools/go.sum
Falling back to patching base and 3-way merge...
Auto-merging hack/tools/go.sum
CONFLICT (content): Merge conflict in hack/tools/go.sum
Auto-merging hack/tools/go.mod
CONFLICT (content): Merge conflict in hack/tools/go.mod
Auto-merging go.sum
Auto-merging go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 uplift go and x/net
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherry-pick release-0.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid tuminoid deleted the tuomo/uplift-go-and-x-net branch February 17, 2023 15:30
@lentzi90
Copy link
Contributor

lentzi90 commented Feb 20, 2023

@tuminoid could you do a PR for release-0.7 also?
I created #1485 for this

@tuminoid
Copy link
Contributor Author

tuminoid commented Mar 2, 2023

Sorry @lentzi90, had a vacation. Thanks for taking care of it.

@lentzi90
Copy link
Contributor

lentzi90 commented Mar 2, 2023

No worries 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants