Skip to content

Switch flavor and test templates to external cloud-provider#3105

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
CecileRobertMichon:oot-templates
Mar 6, 2023
Merged

Switch flavor and test templates to external cloud-provider#3105
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
CecileRobertMichon:oot-templates

Conversation

@CecileRobertMichon
Copy link
Copy Markdown
Contributor

@CecileRobertMichon CecileRobertMichon commented Jan 27, 2023 •
edited
Loading

What type of PR is this?

What this PR does / why we need it: In tree cloud-providers are deprecated and will soon be removed. This updates most templates in flavors/ and tests/ to use the out-of-tree cloud-provider.

Some notes:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2162
Fixes #715

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Switch all reference and test templates to use external cloud-provider-azure
action required: all clusters created from templates in the CAPZ repo must now install cloud-provider-azure as a separate step, see https://capz.sigs.k8s.io/topics/addons.html#external-cloud-provider for instructions.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 27, 2023
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 27, 2023
@CecileRobertMichon
Copy link
Copy Markdown
Contributor Author

CecileRobertMichon commented Jan 27, 2023

/test all

@CecileRobertMichon
Copy link
Copy Markdown
Contributor Author

CecileRobertMichon commented Jan 27, 2023

/test pull-cluster-api-provider-azure-e2e-optional

1 similar comment
@CecileRobertMichon
Copy link
Copy Markdown
Contributor Author

CecileRobertMichon commented Jan 27, 2023

/test pull-cluster-api-provider-azure-e2e-optional

@jackfrancis jackfrancis mentioned this pull request Jan 31, 2023
Closed
3 tasks
@CecileRobertMichon CecileRobertMichon modified the milestone: v1.8 Feb 1, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 1, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 3, 2023
@CecileRobertMichon
Copy link
Copy Markdown
Contributor Author

CecileRobertMichon commented Feb 3, 2023

/test pull-cluster-api-provider-azure-e2e-optional

@CecileRobertMichon CecileRobertMichon mentioned this pull request Feb 3, 2023
Closed
@CecileRobertMichon
Copy link
Copy Markdown
Contributor Author

CecileRobertMichon commented Feb 3, 2023

/test pull-cluster-api-provider-azure-e2e
/test pull-cluster-api-provider-azure-e2e-optional

@CecileRobertMichon
Copy link
Copy Markdown
Contributor Author

CecileRobertMichon commented Feb 6, 2023

/test pull-cluster-api-provider-azure-e2e-optional

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 8, 2023
@CecileRobertMichon CecileRobertMichon mentioned this pull request Feb 10, 2023
Merged
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 10, 2023
@CecileRobertMichon
Copy link
Copy Markdown
Contributor Author

CecileRobertMichon commented Feb 10, 2023

/test pull-cluster-api-provider-azure-e2e-optional

@CecileRobertMichon
Copy link
Copy Markdown
Contributor Author

CecileRobertMichon commented Feb 10, 2023

/test pull-cluster-api-provider-azure-capi-e2e

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 10, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 10, 2023
@CecileRobertMichon CecileRobertMichon mentioned this pull request Feb 10, 2023
Merged
3 tasks
@CecileRobertMichon
Copy link
Copy Markdown
Contributor Author

CecileRobertMichon commented Mar 3, 2023

/test pull-cluster-api-provider-azure-capi-e2e
/test pull-cluster-api-provider-azure-e2e-optional
/test pull-cluster-api-provider-azure-e2e-workload-upgrade

@jackfrancis
Copy link
Copy Markdown
Contributor

jackfrancis commented Mar 3, 2023

/retest

jackfrancis
jackfrancis reviewed Mar 3, 2023
View reviewed changes
Comment thread scripts/ci-entrypoint.sh
jackfrancis
jackfrancis reviewed Mar 3, 2023
View reviewed changes
Comment thread scripts/ci-entrypoint.sh
jackfrancis
jackfrancis reviewed Mar 3, 2023
View reviewed changes
Comment thread test/e2e/cloud-provider-azure.go
jackfrancis
jackfrancis reviewed Mar 3, 2023
View reviewed changes
Comment thread test/e2e/common.go
jackfrancis
jackfrancis reviewed Mar 3, 2023
View reviewed changes
Comment thread test/e2e/config/azure-dev.yaml
@jackfrancis
Copy link
Copy Markdown
Contributor

jackfrancis commented Mar 3, 2023

/retest

@jackfrancis
Copy link
Copy Markdown
Contributor

jackfrancis commented Mar 4, 2023

/lgtm
/approve

🚀

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2023
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 4, 2023

LGTM label has been added.

DetailsGit tree hash: 31f386d99f8aa1c8c233a75836029a6b75440abc

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2023
@CecileRobertMichon
Copy link
Copy Markdown
Contributor Author

CecileRobertMichon commented Mar 4, 2023

/hold

let's merge this Monday a.m. just in case...

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 4, 2023
@jackfrancis
Copy link
Copy Markdown
Contributor

jackfrancis commented Mar 6, 2023

/retest

1 similar comment
@jackfrancis
Copy link
Copy Markdown
Contributor

jackfrancis commented Mar 6, 2023

/retest

@jackfrancis jackfrancis mentioned this pull request Mar 6, 2023
Merged
3 tasks
@jackfrancis
Copy link
Copy Markdown
Contributor

jackfrancis commented Mar 6, 2023

/hold cancel

🐎

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 6, 2023
@k8s-ci-robot k8s-ci-robot merged commit 5b002b9 into kubernetes-sigs:main Mar 6, 2023
@CecileRobertMichon CecileRobertMichon mentioned this pull request Mar 7, 2023
Merged
3 tasks
This was referenced Mar 10, 2023
Closed
Closed
@CecileRobertMichon CecileRobertMichon mentioned this pull request Mar 30, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackfrancis jackfrancis jackfrancis left review comments

@marosset marosset Awaiting requested review from marosset

@mboersma mboersma Awaiting requested review from mboersma

@lzhecheng lzhecheng Awaiting requested review from lzhecheng

@willie-yao willie-yao Awaiting requested review from willie-yao

Assignees

@jackfrancis jackfrancis

@lzhecheng lzhecheng

@marosset marosset

@willie-yao willie-yao

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

v1.8

Development

Successfully merging this pull request may close these issues.

CAPZ should use Out of Tree cloud-controller-manager and Storage Drivers

7 participants

@CecileRobertMichon @k8s-ci-robot @nawazkh @jackfrancis @lzhecheng @willie-yao @marosset