more explicit delete in ci-entrypoint

[jackfrancis]

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

This PR adds more explicit handling mgmt (kind) and workload cluster operations in ci-entrypoint.sh so that we can more reliably clean up after ourselves following runs. Specifically:

• Persists a kubeconfig file in a well-known location so that downstream scripts can explicitly reference it, rather than rely upon their implicit kubeconfig context pointing at the right place.
• A more specific consumption of the SKIP_CLEANUP variable: we only skip the cleanup phase if it is explicitly set to the "true" value.
• A more consistent dispatching of the KIND_CLUSTER_NAME environment variable upstream and downstream of ci-entrypoint, so that can more explicitly track, target, and delete the management cluster.
• Remove the timeout wrapping around the cluster delete operation, and display a message if the delete operation fails
• Remove the cleanup func and instead include the two cleanup statements (delete workload cluster and delete management cluster) in the flow of the trapped on_exit func
  • this is due to observed edge cases in my macos environment and speculation that perhaps this is not a fully supported bash runtime composition pattern across all implementations of bash

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

NONE

[sonasingh46]

/lgtm
PS: Have also verified by pulling in the changes.

[k8s-ci-robot]

LGTM label has been added.

Details

Git tree hash: da2e2c61b01a123641ac65ab7115a5abac6d5ad4

[mboersma]

/lgtm
/approve

[jackfrancis]

/hold

I might want to advocate for another add'l change to the cleanup foo

[CecileRobertMichon]

/lgtm
/approve
/cherry-pick release-1.7

[k8s-infra-cherrypick-robot]

@CecileRobertMichon: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you.

Details

In response to this:

/lgtm
/approve
/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

LGTM label has been added.

Details

Git tree hash: c6123dc44250c8e14f434e096879aa278f26ca36

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [CecileRobertMichon,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[CecileRobertMichon]

feel free to remove the hold when ready @jackfrancis

[CecileRobertMichon]

/retest
/hold cancel

[jackfrancis]

/retest

[CecileRobertMichon]

:(

/retest

[jackfrancis]

/hold

I prefer that #3105 land first!

[CecileRobertMichon]

/hold cancel

[jackfrancis]

/retest

[jackfrancis]

/retest

[k8s-infra-cherrypick-robot]

@CecileRobertMichon: new pull request created: #3235

Details

In response to this:

/lgtm
/approve
/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.