Build CCM when using k8s version latest in ci-entrypoint#3233
Merged
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
cncf-cla: yes
Contributor
Author
|
/hold this needs a test-infra PR with it |
k8s-ci-robot
added
the
do-not-merge/hold
jackfrancis
reviewed
Mar 7, 2023
| } | ||
|
|
||
| capz::util::should_build_ccm() { | ||
| # TEST_CCM is an environment variable set by a prow job to indicate that the CCM should be built and tested. |
Contributor
There was a problem hiding this comment.
Thanks for the comments!
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. DetailsGit tree hash: 1e4610d7fc1b2f06b54829e7692d6b6124965b18 |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Contributor
|
/retest |
Contributor
|
/retest There aren't enough emojis... |
Contributor
Author
/hold cancel I'll open that PR shortly but no need to wait for it since the jobs this is fixing are already broken.... |
k8s-ci-robot
removed
the
do-not-merge/hold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind failing-test
What this PR does / why we need it: Fixes regression from #3105 where CCM is not getting built for CSI driver tests that use ci-entrypoint but don't test CCM: https://testgrid.k8s.io/provider-azure-master-signal#capz-azure-disk, resulting in an invalid Helm image version as the k8s version doesn't exist.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: