Skip to content

ci: external cloud-provider-azure includes Windows#2865

Closed
jackfrancis wants to merge 1 commit into
kubernetes-sigs:mainfrom
jackfrancis:ci-external-cloud-provider-azure-windows
Closed

ci: external cloud-provider-azure includes Windows#2865
jackfrancis wants to merge 1 commit into
kubernetes-sigs:mainfrom
jackfrancis:ci-external-cloud-provider-azure-windows

Conversation

@jackfrancis
Copy link
Copy Markdown
Contributor

@jackfrancis jackfrancis commented Nov 29, 2022

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

This PR adds a Windows node pool to the external cloud-provider-azure test scenario.

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

test Windows external cloud-provider-azure

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 29, 2022
@jackfrancis jackfrancis changed the title ci: external cloud-provider-azure includes Windows WIP ci: external cloud-provider-azure includes Windows Nov 29, 2022
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Nov 29, 2022
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 29, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jackfrancis by writing /assign @jackfrancis in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 30, 2022
@jackfrancis jackfrancis added this to the v1.7 milestone Dec 1, 2022
@jackfrancis jackfrancis force-pushed the ci-external-cloud-provider-azure-windows branch from dae7790 to 980ab84 Compare December 1, 2022 23:26
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 1, 2022
@jackfrancis jackfrancis changed the title WIP ci: external cloud-provider-azure includes Windows ci: external cloud-provider-azure includes Windows Dec 1, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 1, 2022
@CecileRobertMichon
Copy link
Copy Markdown
Contributor

CecileRobertMichon commented Dec 2, 2022

AFAIK we're not actually testing OOT cloud-provider in PRs if we don't run

/test pull-cluster-api-provider-azure-e2e-optional

@jackfrancis jackfrancis force-pushed the ci-external-cloud-provider-azure-windows branch from 980ab84 to 87fa236 Compare December 2, 2022 18:59
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 2, 2022
@jackfrancis jackfrancis changed the title ci: external cloud-provider-azure includes Windows WIP ci: external cloud-provider-azure includes Windows Dec 2, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 2, 2022
@jackfrancis
Copy link
Copy Markdown
Contributor Author

jackfrancis commented Dec 7, 2022

/test pull-cluster-api-provider-azure-e2e-optional

@jackfrancis jackfrancis changed the title WIP ci: external cloud-provider-azure includes Windows ci: external cloud-provider-azure includes Windows Dec 7, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 7, 2022
@jackfrancis jackfrancis modified the milestones: v1.7, next Jan 5, 2023
@CecileRobertMichon
Copy link
Copy Markdown
Contributor

CecileRobertMichon commented Jan 19, 2023

@jackfrancis should we close this in favor of #2165? I'm going to be starting on that one soon

@jackfrancis
Copy link
Copy Markdown
Contributor Author

jackfrancis commented Jan 19, 2023

@CecileRobertMichon I think that if we get this working in this PR it'll make that other workstream a bit easier (you'll already have the Windows part done).

I don't recall if the test failure is a signal here, lemme retest this PR.

@jackfrancis jackfrancis force-pushed the ci-external-cloud-provider-azure-windows branch from 87fa236 to b987c1f Compare January 19, 2023 00:11
@jackfrancis
Copy link
Copy Markdown
Contributor Author

jackfrancis commented Jan 19, 2023

/test pull-cluster-api-provider-azure-e2e-optional

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 19, 2023 •
edited
Loading

@jackfrancis: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-windows-containerd-upstream-with-ci-artifacts b987c1f link false /test pull-cluster-api-provider-azure-windows-containerd-upstream-with-ci-artifacts
pull-cluster-api-provider-azure-e2e-optional b987c1f link false /test pull-cluster-api-provider-azure-e2e-optional
pull-cluster-api-provider-azure-e2e b987c1f link true /test pull-cluster-api-provider-azure-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jackfrancis jackfrancis modified the milestones: next, v1.8 Jan 19, 2023
@jackfrancis
Copy link
Copy Markdown
Contributor Author

jackfrancis commented Jan 31, 2023

Closing in favor of #3105

@jackfrancis jackfrancis deleted the ci-external-cloud-provider-azure-windows branch January 31, 2023 17:44
@CecileRobertMichon CecileRobertMichon mentioned this pull request Feb 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devigned devigned Awaiting requested review from devigned

@Jont828 Jont828 Awaiting requested review from Jont828

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v1.8

Development

Successfully merging this pull request may close these issues.

3 participants

@jackfrancis @k8s-ci-robot @CecileRobertMichon