Skip to content

Add cloud-provider-azure ccm test with CAPZ#21915

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
CecileRobertMichon:add-capz-ccm-test
Apr 23, 2021
Merged

Add cloud-provider-azure ccm test with CAPZ#21915
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
CecileRobertMichon:add-capz-ccm-test

Conversation

@CecileRobertMichon
Copy link
Copy Markdown
Member

@CecileRobertMichon CecileRobertMichon commented Apr 22, 2021

Add optional/don't run by default presubmit job to test kubernetes-sigs/cluster-api-provider-azure#1330.

After kubernetes-sigs/cluster-api-provider-azure#1330 is merged, branch should be updated to kubernetes-sigs/cluster-api-provider-azure:master.

/assign @chewong

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 22, 2021
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs area/provider/azure Issues or PRs related to azure provider sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 22, 2021
@chewong
Copy link
Copy Markdown
Member

chewong commented Apr 22, 2021

lgtm
pending @feiskyer's review

@CecileRobertMichon CecileRobertMichon force-pushed the add-capz-ccm-test branch 2 times, most recently from 031e8c5 to 35ae6c4 Compare April 22, 2021 21:33
CecileRobertMichon
CecileRobertMichon commented Apr 22, 2021
View reviewed changes
Comment thread config/jobs/kubernetes-sigs/cloud-provider-azure/cloud-provider-azure-config.yaml
value: "true"
- name: K8S_AZURE_LOADBALANCE_SKU
value: "standard"
- name: AZURE_LOADBALANCER_SKU
Copy link
Copy Markdown
Member Author

@CecileRobertMichon CecileRobertMichon Apr 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is for #21917

feiskyer
feiskyer approved these changes Apr 23, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for adding this.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit c1fad09 into kubernetes:master Apr 23, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Apr 23, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 23, 2021

@CecileRobertMichon: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cloud-provider-azure-config.yaml using file config/jobs/kubernetes-sigs/cloud-provider-azure/cloud-provider-azure-config.yaml
Details

In response to this:

Add optional/don't run by default presubmit job to test kubernetes-sigs/cluster-api-provider-azure#1330.

After kubernetes-sigs/cluster-api-provider-azure#1330 is merged, branch should be updated to kubernetes-sigs/cluster-api-provider-azure:master.

/assign @chewong

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@justaugustus justaugustus Awaiting requested review from justaugustus

1 more reviewer

@feiskyer feiskyer feiskyer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@feiskyer feiskyer

@chewong chewong

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v1.22

Development

Successfully merging this pull request may close these issues.

4 participants

@CecileRobertMichon @chewong @k8s-ci-robot @feiskyer