Small improvements in ci-entrypoint script #1334
Merged
k8s-ci-robot merged 3 commits intoApr 24, 2021
Merged
Conversation
Contributor
Author
k8s-ci-robot
added
the
release-note-none
k8s-ci-robot
added
area/provider/azure
k8s-ci-robot
added
the
cncf-cla: yes
chewong
reviewed
Apr 23, 2021
CecileRobertMichon
force-pushed
the
fix-scripts
branch
from
710c406 to
96979c1
Compare
3 tasks
k8s-ci-robot
added
the
do-not-merge/hold
CecileRobertMichon
force-pushed
the
fix-scripts
branch
from
96979c1 to
35f86c2
Compare
Contributor
Author
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
devigned
approved these changes
Apr 24, 2021
Contributor
devigned
left a comment
devigned
left a comment
There was a problem hiding this comment.
Like what you've done with the ensure-acr-cleanup-schedule.sh. What do you think about an issue to add that script to a periodic job to ensure the job says up-to-date?
/lgtm
/approve
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: devigned The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
3 tasks
3 tasks
willie-yao
pushed a commit
to willie-yao/cluster-api-provider-azure
that referenced
this pull request
Jul 11, 2025
Signed-off-by: Jeremy Rickard <jrickard@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it: Broke out unrelated changes from #1330. Add a random region selection to avoid quota issues, refactored ACR login into a script and made sure REGISTRY is set, updated ACR cleanup tasks (see kubernetes/test-infra#21933), and fixed a typo in cert-manager version.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: