Skip to content

Makes the number of worker threads configurable.#282

Merged
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
huffmanca:issue276
Mar 31, 2020
Merged

Makes the number of worker threads configurable.#282
k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
huffmanca:issue276

Conversation

@huffmanca
Copy link
Copy Markdown
Contributor

@huffmanca huffmanca commented Mar 30, 2020 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
Adjusts the worker threads to be configurable for the snapshot-controller and csi-snapshotter.

Which issue(s) this PR fixes:
Fixes #276

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

The number of worker threads in the snapshot-controller and csi-snapshotter is now configurable via the `worker-threads` flag.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 30, 2020
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 30, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 30, 2020

Hi @huffmanca. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 30, 2020
@xing-yang
Copy link
Copy Markdown
Collaborator

xing-yang commented Mar 30, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 30, 2020
msau42
msau42 reviewed Mar 31, 2020
View reviewed changes
Comment thread cmd/csi-snapshotter/main.go Outdated
snapshotNamePrefix = flag.String("snapshot-name-prefix", "snapshot", "Prefix to apply to the name of a created snapshot")
snapshotNameUUIDLength = flag.Int("snapshot-name-uuid-length", -1, "Length in characters for the generated uuid of a created snapshot. Defaults behavior is to NOT truncate.")
showVersion = flag.Bool("version", false, "Show version.")
threads = flag.Int("threads", 10, "Number of worker threads.")
Copy link
Copy Markdown
Collaborator

@msau42 msau42 Mar 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the same flag name as the other sidecars?

Copy link
Copy Markdown
Contributor Author

@huffmanca huffmanca Mar 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated this to be worker-threads to match the external-attacher.

@msau42
Copy link
Copy Markdown
Collaborator

msau42 commented Mar 31, 2020

/lgtm
also update the release note thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 31, 2020
@huffmanca
Copy link
Copy Markdown
Contributor Author

huffmanca commented Mar 31, 2020

Done. Thank you for the release note reminder!

@xing-yang
Copy link
Copy Markdown
Collaborator

xing-yang commented Mar 31, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 31, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huffmanca, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2020
@k8s-ci-robot k8s-ci-robot merged commit 69db084 into kubernetes-csi:master Mar 31, 2020
dobsonj added a commit to dobsonj/external-snapshotter that referenced this pull request Sep 4, 2025
@dobsonj
Squashed 'release-tools/' changes from 0a435bf98..5f38a9075
e0348f9 
5f38a9075 Merge pull request kubernetes-csi#282 from rhrmo/update-go-1.24.6
579f62421 Update go to 1.24.6
74e066a82 Merge pull request kubernetes-csi#279 from Aishwarya-Hebbar/update-csi-prow-version
6f236be7d Update CSI prow driver version to v1.17.0
0ee55894b Merge pull request kubernetes-csi#280 from xing-yang/update_go_1.24.4
9af101534 update to go 1.24.4
f5fec3e36 Merge pull request kubernetes-csi#275 from chrishenzie/emeritus
c5d285db8 Remove chrishenzie from kubernetes-csi-reviewers

git-subtree-dir: release-tools
git-subtree-split: 5f38a907597230563f5e2213aea116acdd9d86bc
akankshapanse added a commit to akankshapanse/external-snapshotter that referenced this pull request Mar 13, 2026
@akankshapanse
Squashed 'release-tools/' changes from 90efb2ca5..119a53c3c
2a7009b 
119a53c3c Merge pull request kubernetes-csi#294 from andyzhangx/patch-10
7c9aa9ba3 fix: upgrade to go1.25.7 to fix CVE-2026-25679
1e81e752e Merge pull request kubernetes-csi#293 from andyzhangx/patch-9
4dc185057 fix: upgrade to go1.25.7 to fix CVE-2025-61727
b60b9a507 Merge pull request kubernetes-csi#292 from andyzhangx/patch-8
0e4e2ed0d Update Go version from 1.25.5 to 1.25.6 to fix CVE
707a99eca Merge pull request kubernetes-csi#291 from dfajmon/logcheck
a9d2b0fb3 Bump logcheck to v0.10.0
d6846630b Merge pull request kubernetes-csi#290 from dfajmon/go-1.25.5
55e527c49 Bump golang to 1.25.5
b12e407cc Merge pull request kubernetes-csi#289 from nixpanic/k8s-v1.34
bbe5e547e Use Kubernetes v1.34 and Kind v0.30 by default
4e9eb2c9e Merge pull request kubernetes-csi#288 from gnufied/add-gnufied-for-csi-approver
064e260d9 Add myself as csi approver
c852fa797 Merge pull request kubernetes-csi#287 from andyzhangx/patch-7
bce16c103 fix: upgrade to go1.24.11 to fix CVE-2025-61727
8d1258cce Merge pull request kubernetes-csi#286 from kubernetes-csi/dependabot/github_actions/actions/checkout-6
91e35981a Bump actions/checkout from 5 to 6
294138155 Merge pull request kubernetes-csi#285 from andyzhangx/patch-6
fa8b339e9 fix: upgrade to go1.24.9 to fix CVEs
74502e544 Merge pull request kubernetes-csi#278 from liangyuanpeng/migrate_k8s_testimages
533443055 Merge pull request kubernetes-csi#281 from kubernetes-csi/dependabot/github_actions/actions/checkout-5
458ce146f Bump actions/checkout from 4 to 5
5f38a9075 Merge pull request kubernetes-csi#282 from rhrmo/update-go-1.24.6
579f62421 Update go to 1.24.6
5ec1a52b8 use gcr.io/k8s-staging-test-infra instead of gcr.io/k8s-testimages
74e066a82 Merge pull request kubernetes-csi#279 from Aishwarya-Hebbar/update-csi-prow-version
6f236be7d Update CSI prow driver version to v1.17.0
0ee55894b Merge pull request kubernetes-csi#280 from xing-yang/update_go_1.24.4
9af101534 update to go 1.24.4
f5fec3e36 Merge pull request kubernetes-csi#275 from chrishenzie/emeritus
c5d285db8 Remove chrishenzie from kubernetes-csi-reviewers
0a435bf98 Merge pull request kubernetes-csi#274 from andyzhangx/patch-5
cd7b4bba3 Bump golang to 1.24.2 to fix CVE-2025-22871
701dc34bc Merge pull request kubernetes-csi#273 from andyzhangx/patch-4
aeebd30e8 Bump golang to 1.24.0
f277d561f Merge pull request kubernetes-csi#270 from carlory/update-kind-version
6dcb96a51 update default kind version to v0.25.0

git-subtree-dir: release-tools
git-subtree-split: 119a53c3cce0c04fd422514252ea62c6ff4e3548
@akankshapanse akankshapanse mentioned this pull request Mar 16, 2026
Open
xing-yang added a commit to xing-yang/external-snapshotter that referenced this pull request Mar 19, 2026
@xing-yang
Squashed 'release-tools/' changes from 0a435bf98..119a53c3c
bd5c67b 
119a53c3c Merge pull request kubernetes-csi#294 from andyzhangx/patch-10
7c9aa9ba3 fix: upgrade to go1.25.7 to fix CVE-2026-25679
1e81e752e Merge pull request kubernetes-csi#293 from andyzhangx/patch-9
4dc185057 fix: upgrade to go1.25.7 to fix CVE-2025-61727
b60b9a507 Merge pull request kubernetes-csi#292 from andyzhangx/patch-8
0e4e2ed0d Update Go version from 1.25.5 to 1.25.6 to fix CVE
707a99eca Merge pull request kubernetes-csi#291 from dfajmon/logcheck
a9d2b0fb3 Bump logcheck to v0.10.0
d6846630b Merge pull request kubernetes-csi#290 from dfajmon/go-1.25.5
55e527c49 Bump golang to 1.25.5
b12e407cc Merge pull request kubernetes-csi#289 from nixpanic/k8s-v1.34
bbe5e547e Use Kubernetes v1.34 and Kind v0.30 by default
4e9eb2c9e Merge pull request kubernetes-csi#288 from gnufied/add-gnufied-for-csi-approver
064e260d9 Add myself as csi approver
c852fa797 Merge pull request kubernetes-csi#287 from andyzhangx/patch-7
bce16c103 fix: upgrade to go1.24.11 to fix CVE-2025-61727
8d1258cce Merge pull request kubernetes-csi#286 from kubernetes-csi/dependabot/github_actions/actions/checkout-6
91e35981a Bump actions/checkout from 5 to 6
294138155 Merge pull request kubernetes-csi#285 from andyzhangx/patch-6
fa8b339e9 fix: upgrade to go1.24.9 to fix CVEs
74502e544 Merge pull request kubernetes-csi#278 from liangyuanpeng/migrate_k8s_testimages
533443055 Merge pull request kubernetes-csi#281 from kubernetes-csi/dependabot/github_actions/actions/checkout-5
458ce146f Bump actions/checkout from 4 to 5
5f38a9075 Merge pull request kubernetes-csi#282 from rhrmo/update-go-1.24.6
579f62421 Update go to 1.24.6
5ec1a52b8 use gcr.io/k8s-staging-test-infra instead of gcr.io/k8s-testimages
74e066a82 Merge pull request kubernetes-csi#279 from Aishwarya-Hebbar/update-csi-prow-version
6f236be7d Update CSI prow driver version to v1.17.0
0ee55894b Merge pull request kubernetes-csi#280 from xing-yang/update_go_1.24.4
9af101534 update to go 1.24.4
f5fec3e36 Merge pull request kubernetes-csi#275 from chrishenzie/emeritus
c5d285db8 Remove chrishenzie from kubernetes-csi-reviewers

git-subtree-dir: release-tools
git-subtree-split: 119a53c3cce0c04fd422514252ea62c6ff4e3548
@xing-yang xing-yang mentioned this pull request Mar 19, 2026
Merged
akankshapanse added a commit to akankshapanse/external-snapshotter that referenced this pull request Mar 20, 2026
@akankshapanse
Squashed 'release-tools/' changes from 90efb2ca5..119a53c3c
52b5131 
119a53c3c Merge pull request kubernetes-csi#294 from andyzhangx/patch-10
7c9aa9ba3 fix: upgrade to go1.25.7 to fix CVE-2026-25679
1e81e752e Merge pull request kubernetes-csi#293 from andyzhangx/patch-9
4dc185057 fix: upgrade to go1.25.7 to fix CVE-2025-61727
b60b9a507 Merge pull request kubernetes-csi#292 from andyzhangx/patch-8
0e4e2ed0d Update Go version from 1.25.5 to 1.25.6 to fix CVE
707a99eca Merge pull request kubernetes-csi#291 from dfajmon/logcheck
a9d2b0fb3 Bump logcheck to v0.10.0
d6846630b Merge pull request kubernetes-csi#290 from dfajmon/go-1.25.5
55e527c49 Bump golang to 1.25.5
b12e407cc Merge pull request kubernetes-csi#289 from nixpanic/k8s-v1.34
bbe5e547e Use Kubernetes v1.34 and Kind v0.30 by default
4e9eb2c9e Merge pull request kubernetes-csi#288 from gnufied/add-gnufied-for-csi-approver
064e260d9 Add myself as csi approver
c852fa797 Merge pull request kubernetes-csi#287 from andyzhangx/patch-7
bce16c103 fix: upgrade to go1.24.11 to fix CVE-2025-61727
8d1258cce Merge pull request kubernetes-csi#286 from kubernetes-csi/dependabot/github_actions/actions/checkout-6
91e35981a Bump actions/checkout from 5 to 6
294138155 Merge pull request kubernetes-csi#285 from andyzhangx/patch-6
fa8b339e9 fix: upgrade to go1.24.9 to fix CVEs
74502e544 Merge pull request kubernetes-csi#278 from liangyuanpeng/migrate_k8s_testimages
533443055 Merge pull request kubernetes-csi#281 from kubernetes-csi/dependabot/github_actions/actions/checkout-5
458ce146f Bump actions/checkout from 4 to 5
5f38a9075 Merge pull request kubernetes-csi#282 from rhrmo/update-go-1.24.6
579f62421 Update go to 1.24.6
5ec1a52b8 use gcr.io/k8s-staging-test-infra instead of gcr.io/k8s-testimages
74e066a82 Merge pull request kubernetes-csi#279 from Aishwarya-Hebbar/update-csi-prow-version
6f236be7d Update CSI prow driver version to v1.17.0
0ee55894b Merge pull request kubernetes-csi#280 from xing-yang/update_go_1.24.4
9af101534 update to go 1.24.4
f5fec3e36 Merge pull request kubernetes-csi#275 from chrishenzie/emeritus
c5d285db8 Remove chrishenzie from kubernetes-csi-reviewers
0a435bf98 Merge pull request kubernetes-csi#274 from andyzhangx/patch-5
cd7b4bba3 Bump golang to 1.24.2 to fix CVE-2025-22871
701dc34bc Merge pull request kubernetes-csi#273 from andyzhangx/patch-4
aeebd30e8 Bump golang to 1.24.0
f277d561f Merge pull request kubernetes-csi#270 from carlory/update-kind-version
6dcb96a51 update default kind version to v0.25.0

git-subtree-dir: release-tools
git-subtree-split: 119a53c3cce0c04fd422514252ea62c6ff4e3548
akankshapanse added a commit to akankshapanse/external-snapshotter that referenced this pull request Mar 23, 2026
@akankshapanse
Squashed 'release-tools/' changes from 90efb2ca5..119a53c3c
419f969 
119a53c3c Merge pull request kubernetes-csi#294 from andyzhangx/patch-10
7c9aa9ba3 fix: upgrade to go1.25.7 to fix CVE-2026-25679
1e81e752e Merge pull request kubernetes-csi#293 from andyzhangx/patch-9
4dc185057 fix: upgrade to go1.25.7 to fix CVE-2025-61727
b60b9a507 Merge pull request kubernetes-csi#292 from andyzhangx/patch-8
0e4e2ed0d Update Go version from 1.25.5 to 1.25.6 to fix CVE
707a99eca Merge pull request kubernetes-csi#291 from dfajmon/logcheck
a9d2b0fb3 Bump logcheck to v0.10.0
d6846630b Merge pull request kubernetes-csi#290 from dfajmon/go-1.25.5
55e527c49 Bump golang to 1.25.5
b12e407cc Merge pull request kubernetes-csi#289 from nixpanic/k8s-v1.34
bbe5e547e Use Kubernetes v1.34 and Kind v0.30 by default
4e9eb2c9e Merge pull request kubernetes-csi#288 from gnufied/add-gnufied-for-csi-approver
064e260d9 Add myself as csi approver
c852fa797 Merge pull request kubernetes-csi#287 from andyzhangx/patch-7
bce16c103 fix: upgrade to go1.24.11 to fix CVE-2025-61727
8d1258cce Merge pull request kubernetes-csi#286 from kubernetes-csi/dependabot/github_actions/actions/checkout-6
91e35981a Bump actions/checkout from 5 to 6
294138155 Merge pull request kubernetes-csi#285 from andyzhangx/patch-6
fa8b339e9 fix: upgrade to go1.24.9 to fix CVEs
74502e544 Merge pull request kubernetes-csi#278 from liangyuanpeng/migrate_k8s_testimages
533443055 Merge pull request kubernetes-csi#281 from kubernetes-csi/dependabot/github_actions/actions/checkout-5
458ce146f Bump actions/checkout from 4 to 5
5f38a9075 Merge pull request kubernetes-csi#282 from rhrmo/update-go-1.24.6
579f62421 Update go to 1.24.6
5ec1a52b8 use gcr.io/k8s-staging-test-infra instead of gcr.io/k8s-testimages
74e066a82 Merge pull request kubernetes-csi#279 from Aishwarya-Hebbar/update-csi-prow-version
6f236be7d Update CSI prow driver version to v1.17.0
0ee55894b Merge pull request kubernetes-csi#280 from xing-yang/update_go_1.24.4
9af101534 update to go 1.24.4
f5fec3e36 Merge pull request kubernetes-csi#275 from chrishenzie/emeritus
c5d285db8 Remove chrishenzie from kubernetes-csi-reviewers
0a435bf98 Merge pull request kubernetes-csi#274 from andyzhangx/patch-5
cd7b4bba3 Bump golang to 1.24.2 to fix CVE-2025-22871
701dc34bc Merge pull request kubernetes-csi#273 from andyzhangx/patch-4
aeebd30e8 Bump golang to 1.24.0
f277d561f Merge pull request kubernetes-csi#270 from carlory/update-kind-version
6dcb96a51 update default kind version to v0.25.0

git-subtree-dir: release-tools
git-subtree-split: 119a53c3cce0c04fd422514252ea62c6ff4e3548
akankshapanse added a commit to akankshapanse/external-snapshotter that referenced this pull request Mar 24, 2026
@akankshapanse
Squashed 'release-tools/' changes from 90efb2ca5..119a53c3c
849b149 
119a53c3c Merge pull request kubernetes-csi#294 from andyzhangx/patch-10
7c9aa9ba3 fix: upgrade to go1.25.7 to fix CVE-2026-25679
1e81e752e Merge pull request kubernetes-csi#293 from andyzhangx/patch-9
4dc185057 fix: upgrade to go1.25.7 to fix CVE-2025-61727
b60b9a507 Merge pull request kubernetes-csi#292 from andyzhangx/patch-8
0e4e2ed0d Update Go version from 1.25.5 to 1.25.6 to fix CVE
707a99eca Merge pull request kubernetes-csi#291 from dfajmon/logcheck
a9d2b0fb3 Bump logcheck to v0.10.0
d6846630b Merge pull request kubernetes-csi#290 from dfajmon/go-1.25.5
55e527c49 Bump golang to 1.25.5
b12e407cc Merge pull request kubernetes-csi#289 from nixpanic/k8s-v1.34
bbe5e547e Use Kubernetes v1.34 and Kind v0.30 by default
4e9eb2c9e Merge pull request kubernetes-csi#288 from gnufied/add-gnufied-for-csi-approver
064e260d9 Add myself as csi approver
c852fa797 Merge pull request kubernetes-csi#287 from andyzhangx/patch-7
bce16c103 fix: upgrade to go1.24.11 to fix CVE-2025-61727
8d1258cce Merge pull request kubernetes-csi#286 from kubernetes-csi/dependabot/github_actions/actions/checkout-6
91e35981a Bump actions/checkout from 5 to 6
294138155 Merge pull request kubernetes-csi#285 from andyzhangx/patch-6
fa8b339e9 fix: upgrade to go1.24.9 to fix CVEs
74502e544 Merge pull request kubernetes-csi#278 from liangyuanpeng/migrate_k8s_testimages
533443055 Merge pull request kubernetes-csi#281 from kubernetes-csi/dependabot/github_actions/actions/checkout-5
458ce146f Bump actions/checkout from 4 to 5
5f38a9075 Merge pull request kubernetes-csi#282 from rhrmo/update-go-1.24.6
579f62421 Update go to 1.24.6
5ec1a52b8 use gcr.io/k8s-staging-test-infra instead of gcr.io/k8s-testimages
74e066a82 Merge pull request kubernetes-csi#279 from Aishwarya-Hebbar/update-csi-prow-version
6f236be7d Update CSI prow driver version to v1.17.0
0ee55894b Merge pull request kubernetes-csi#280 from xing-yang/update_go_1.24.4
9af101534 update to go 1.24.4
f5fec3e36 Merge pull request kubernetes-csi#275 from chrishenzie/emeritus
c5d285db8 Remove chrishenzie from kubernetes-csi-reviewers
0a435bf98 Merge pull request kubernetes-csi#274 from andyzhangx/patch-5
cd7b4bba3 Bump golang to 1.24.2 to fix CVE-2025-22871
701dc34bc Merge pull request kubernetes-csi#273 from andyzhangx/patch-4
aeebd30e8 Bump golang to 1.24.0
f277d561f Merge pull request kubernetes-csi#270 from carlory/update-kind-version
6dcb96a51 update default kind version to v0.25.0

git-subtree-dir: release-tools
git-subtree-split: 119a53c3cce0c04fd422514252ea62c6ff4e3548
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msau42 msau42 msau42 left review comments

@saad-ali saad-ali Awaiting requested review from saad-ali

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@xing-yang xing-yang

@msau42 msau42

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Number of worker threads should be configurable

4 participants

@huffmanca @k8s-ci-robot @xing-yang @msau42