Allows VolumeSnapshot to be deleted if the class isn't found#275
Conversation
|
Hi @huffmanca. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
d751462 to
9745d48
Compare
|
@xing-yang - this should be ready for review |
9745d48 to
3bb0af2
Compare
|
I also removed the second commit and submitted it as a separate PR in #278 . |
3bb0af2 to
e0cbed7
Compare
e0cbed7 to
3ade34d
Compare
43cafda to
f91c359
Compare
c88f93b to
4791370
Compare
| // If the VolumeSnapshotClass is not found, we still need to process an update | ||
| // so that syncSnapshot can delete the snapshot, should it still exist in the | ||
| // cluster after it's been removed from the informer cache | ||
| klog.V(5).Infof("passed checkAndUpdateSnapshotClass for snapshot %q, or snapshot needs to be deleted and snapshotClass doesn't exist", key) |
There was a problem hiding this comment.
Suggest change to the following:
updating snapshot %q; snapshotClass may have already been removed
There was a problem hiding this comment.
This has been changed to use the suggested message.
4791370 to
91a55c0
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: huffmanca, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
74e066a82 Merge pull request kubernetes-csi#279 from Aishwarya-Hebbar/update-csi-prow-version 6f236be7d Update CSI prow driver version to v1.17.0 0ee55894b Merge pull request kubernetes-csi#280 from xing-yang/update_go_1.24.4 9af101534 update to go 1.24.4 f5fec3e36 Merge pull request kubernetes-csi#275 from chrishenzie/emeritus c5d285db8 Remove chrishenzie from kubernetes-csi-reviewers 0a435bf98 Merge pull request kubernetes-csi#274 from andyzhangx/patch-5 cd7b4bba3 Bump golang to 1.24.2 to fix CVE-2025-22871 701dc34bc Merge pull request kubernetes-csi#273 from andyzhangx/patch-4 aeebd30e8 Bump golang to 1.24.0 f277d561f Merge pull request kubernetes-csi#270 from carlory/update-kind-version 6dcb96a51 update default kind version to v0.25.0 git-subtree-dir: release-tools git-subtree-split: 74e066a82d2ea14a68ff37f0e02ddc34619bbccd
74e066a82 Merge pull request kubernetes-csi#279 from Aishwarya-Hebbar/update-csi-prow-version 6f236be7d Update CSI prow driver version to v1.17.0 0ee55894b Merge pull request kubernetes-csi#280 from xing-yang/update_go_1.24.4 9af101534 update to go 1.24.4 f5fec3e36 Merge pull request kubernetes-csi#275 from chrishenzie/emeritus c5d285db8 Remove chrishenzie from kubernetes-csi-reviewers 0a435bf98 Merge pull request kubernetes-csi#274 from andyzhangx/patch-5 cd7b4bba3 Bump golang to 1.24.2 to fix CVE-2025-22871 701dc34bc Merge pull request kubernetes-csi#273 from andyzhangx/patch-4 aeebd30e8 Bump golang to 1.24.0 f277d561f Merge pull request kubernetes-csi#270 from carlory/update-kind-version 6dcb96a51 update default kind version to v0.25.0 git-subtree-dir: release-tools git-subtree-split: 74e066a82d2ea14a68ff37f0e02ddc34619bbccd
5f38a9075 Merge pull request kubernetes-csi#282 from rhrmo/update-go-1.24.6 579f62421 Update go to 1.24.6 74e066a82 Merge pull request kubernetes-csi#279 from Aishwarya-Hebbar/update-csi-prow-version 6f236be7d Update CSI prow driver version to v1.17.0 0ee55894b Merge pull request kubernetes-csi#280 from xing-yang/update_go_1.24.4 9af101534 update to go 1.24.4 f5fec3e36 Merge pull request kubernetes-csi#275 from chrishenzie/emeritus c5d285db8 Remove chrishenzie from kubernetes-csi-reviewers git-subtree-dir: release-tools git-subtree-split: 5f38a907597230563f5e2213aea116acdd9d86bc
119a53c3c Merge pull request kubernetes-csi#294 from andyzhangx/patch-10 7c9aa9ba3 fix: upgrade to go1.25.7 to fix CVE-2026-25679 1e81e752e Merge pull request kubernetes-csi#293 from andyzhangx/patch-9 4dc185057 fix: upgrade to go1.25.7 to fix CVE-2025-61727 b60b9a507 Merge pull request kubernetes-csi#292 from andyzhangx/patch-8 0e4e2ed0d Update Go version from 1.25.5 to 1.25.6 to fix CVE 707a99eca Merge pull request kubernetes-csi#291 from dfajmon/logcheck a9d2b0fb3 Bump logcheck to v0.10.0 d6846630b Merge pull request kubernetes-csi#290 from dfajmon/go-1.25.5 55e527c49 Bump golang to 1.25.5 b12e407cc Merge pull request kubernetes-csi#289 from nixpanic/k8s-v1.34 bbe5e547e Use Kubernetes v1.34 and Kind v0.30 by default 4e9eb2c9e Merge pull request kubernetes-csi#288 from gnufied/add-gnufied-for-csi-approver 064e260d9 Add myself as csi approver c852fa797 Merge pull request kubernetes-csi#287 from andyzhangx/patch-7 bce16c103 fix: upgrade to go1.24.11 to fix CVE-2025-61727 8d1258cce Merge pull request kubernetes-csi#286 from kubernetes-csi/dependabot/github_actions/actions/checkout-6 91e35981a Bump actions/checkout from 5 to 6 294138155 Merge pull request kubernetes-csi#285 from andyzhangx/patch-6 fa8b339e9 fix: upgrade to go1.24.9 to fix CVEs 74502e544 Merge pull request kubernetes-csi#278 from liangyuanpeng/migrate_k8s_testimages 533443055 Merge pull request kubernetes-csi#281 from kubernetes-csi/dependabot/github_actions/actions/checkout-5 458ce146f Bump actions/checkout from 4 to 5 5f38a9075 Merge pull request kubernetes-csi#282 from rhrmo/update-go-1.24.6 579f62421 Update go to 1.24.6 5ec1a52b8 use gcr.io/k8s-staging-test-infra instead of gcr.io/k8s-testimages 74e066a82 Merge pull request kubernetes-csi#279 from Aishwarya-Hebbar/update-csi-prow-version 6f236be7d Update CSI prow driver version to v1.17.0 0ee55894b Merge pull request kubernetes-csi#280 from xing-yang/update_go_1.24.4 9af101534 update to go 1.24.4 f5fec3e36 Merge pull request kubernetes-csi#275 from chrishenzie/emeritus c5d285db8 Remove chrishenzie from kubernetes-csi-reviewers 0a435bf98 Merge pull request kubernetes-csi#274 from andyzhangx/patch-5 cd7b4bba3 Bump golang to 1.24.2 to fix CVE-2025-22871 701dc34bc Merge pull request kubernetes-csi#273 from andyzhangx/patch-4 aeebd30e8 Bump golang to 1.24.0 f277d561f Merge pull request kubernetes-csi#270 from carlory/update-kind-version 6dcb96a51 update default kind version to v0.25.0 git-subtree-dir: release-tools git-subtree-split: 119a53c3cce0c04fd422514252ea62c6ff4e3548
119a53c3c Merge pull request kubernetes-csi#294 from andyzhangx/patch-10 7c9aa9ba3 fix: upgrade to go1.25.7 to fix CVE-2026-25679 1e81e752e Merge pull request kubernetes-csi#293 from andyzhangx/patch-9 4dc185057 fix: upgrade to go1.25.7 to fix CVE-2025-61727 b60b9a507 Merge pull request kubernetes-csi#292 from andyzhangx/patch-8 0e4e2ed0d Update Go version from 1.25.5 to 1.25.6 to fix CVE 707a99eca Merge pull request kubernetes-csi#291 from dfajmon/logcheck a9d2b0fb3 Bump logcheck to v0.10.0 d6846630b Merge pull request kubernetes-csi#290 from dfajmon/go-1.25.5 55e527c49 Bump golang to 1.25.5 b12e407cc Merge pull request kubernetes-csi#289 from nixpanic/k8s-v1.34 bbe5e547e Use Kubernetes v1.34 and Kind v0.30 by default 4e9eb2c9e Merge pull request kubernetes-csi#288 from gnufied/add-gnufied-for-csi-approver 064e260d9 Add myself as csi approver c852fa797 Merge pull request kubernetes-csi#287 from andyzhangx/patch-7 bce16c103 fix: upgrade to go1.24.11 to fix CVE-2025-61727 8d1258cce Merge pull request kubernetes-csi#286 from kubernetes-csi/dependabot/github_actions/actions/checkout-6 91e35981a Bump actions/checkout from 5 to 6 294138155 Merge pull request kubernetes-csi#285 from andyzhangx/patch-6 fa8b339e9 fix: upgrade to go1.24.9 to fix CVEs 74502e544 Merge pull request kubernetes-csi#278 from liangyuanpeng/migrate_k8s_testimages 533443055 Merge pull request kubernetes-csi#281 from kubernetes-csi/dependabot/github_actions/actions/checkout-5 458ce146f Bump actions/checkout from 4 to 5 5f38a9075 Merge pull request kubernetes-csi#282 from rhrmo/update-go-1.24.6 579f62421 Update go to 1.24.6 5ec1a52b8 use gcr.io/k8s-staging-test-infra instead of gcr.io/k8s-testimages 74e066a82 Merge pull request kubernetes-csi#279 from Aishwarya-Hebbar/update-csi-prow-version 6f236be7d Update CSI prow driver version to v1.17.0 0ee55894b Merge pull request kubernetes-csi#280 from xing-yang/update_go_1.24.4 9af101534 update to go 1.24.4 f5fec3e36 Merge pull request kubernetes-csi#275 from chrishenzie/emeritus c5d285db8 Remove chrishenzie from kubernetes-csi-reviewers git-subtree-dir: release-tools git-subtree-split: 119a53c3cce0c04fd422514252ea62c6ff4e3548
119a53c3c Merge pull request kubernetes-csi#294 from andyzhangx/patch-10 7c9aa9ba3 fix: upgrade to go1.25.7 to fix CVE-2026-25679 1e81e752e Merge pull request kubernetes-csi#293 from andyzhangx/patch-9 4dc185057 fix: upgrade to go1.25.7 to fix CVE-2025-61727 b60b9a507 Merge pull request kubernetes-csi#292 from andyzhangx/patch-8 0e4e2ed0d Update Go version from 1.25.5 to 1.25.6 to fix CVE 707a99eca Merge pull request kubernetes-csi#291 from dfajmon/logcheck a9d2b0fb3 Bump logcheck to v0.10.0 d6846630b Merge pull request kubernetes-csi#290 from dfajmon/go-1.25.5 55e527c49 Bump golang to 1.25.5 b12e407cc Merge pull request kubernetes-csi#289 from nixpanic/k8s-v1.34 bbe5e547e Use Kubernetes v1.34 and Kind v0.30 by default 4e9eb2c9e Merge pull request kubernetes-csi#288 from gnufied/add-gnufied-for-csi-approver 064e260d9 Add myself as csi approver c852fa797 Merge pull request kubernetes-csi#287 from andyzhangx/patch-7 bce16c103 fix: upgrade to go1.24.11 to fix CVE-2025-61727 8d1258cce Merge pull request kubernetes-csi#286 from kubernetes-csi/dependabot/github_actions/actions/checkout-6 91e35981a Bump actions/checkout from 5 to 6 294138155 Merge pull request kubernetes-csi#285 from andyzhangx/patch-6 fa8b339e9 fix: upgrade to go1.24.9 to fix CVEs 74502e544 Merge pull request kubernetes-csi#278 from liangyuanpeng/migrate_k8s_testimages 533443055 Merge pull request kubernetes-csi#281 from kubernetes-csi/dependabot/github_actions/actions/checkout-5 458ce146f Bump actions/checkout from 4 to 5 5f38a9075 Merge pull request kubernetes-csi#282 from rhrmo/update-go-1.24.6 579f62421 Update go to 1.24.6 5ec1a52b8 use gcr.io/k8s-staging-test-infra instead of gcr.io/k8s-testimages 74e066a82 Merge pull request kubernetes-csi#279 from Aishwarya-Hebbar/update-csi-prow-version 6f236be7d Update CSI prow driver version to v1.17.0 0ee55894b Merge pull request kubernetes-csi#280 from xing-yang/update_go_1.24.4 9af101534 update to go 1.24.4 f5fec3e36 Merge pull request kubernetes-csi#275 from chrishenzie/emeritus c5d285db8 Remove chrishenzie from kubernetes-csi-reviewers 0a435bf98 Merge pull request kubernetes-csi#274 from andyzhangx/patch-5 cd7b4bba3 Bump golang to 1.24.2 to fix CVE-2025-22871 701dc34bc Merge pull request kubernetes-csi#273 from andyzhangx/patch-4 aeebd30e8 Bump golang to 1.24.0 f277d561f Merge pull request kubernetes-csi#270 from carlory/update-kind-version 6dcb96a51 update default kind version to v0.25.0 git-subtree-dir: release-tools git-subtree-split: 119a53c3cce0c04fd422514252ea62c6ff4e3548
119a53c3c Merge pull request kubernetes-csi#294 from andyzhangx/patch-10 7c9aa9ba3 fix: upgrade to go1.25.7 to fix CVE-2026-25679 1e81e752e Merge pull request kubernetes-csi#293 from andyzhangx/patch-9 4dc185057 fix: upgrade to go1.25.7 to fix CVE-2025-61727 b60b9a507 Merge pull request kubernetes-csi#292 from andyzhangx/patch-8 0e4e2ed0d Update Go version from 1.25.5 to 1.25.6 to fix CVE 707a99eca Merge pull request kubernetes-csi#291 from dfajmon/logcheck a9d2b0fb3 Bump logcheck to v0.10.0 d6846630b Merge pull request kubernetes-csi#290 from dfajmon/go-1.25.5 55e527c49 Bump golang to 1.25.5 b12e407cc Merge pull request kubernetes-csi#289 from nixpanic/k8s-v1.34 bbe5e547e Use Kubernetes v1.34 and Kind v0.30 by default 4e9eb2c9e Merge pull request kubernetes-csi#288 from gnufied/add-gnufied-for-csi-approver 064e260d9 Add myself as csi approver c852fa797 Merge pull request kubernetes-csi#287 from andyzhangx/patch-7 bce16c103 fix: upgrade to go1.24.11 to fix CVE-2025-61727 8d1258cce Merge pull request kubernetes-csi#286 from kubernetes-csi/dependabot/github_actions/actions/checkout-6 91e35981a Bump actions/checkout from 5 to 6 294138155 Merge pull request kubernetes-csi#285 from andyzhangx/patch-6 fa8b339e9 fix: upgrade to go1.24.9 to fix CVEs 74502e544 Merge pull request kubernetes-csi#278 from liangyuanpeng/migrate_k8s_testimages 533443055 Merge pull request kubernetes-csi#281 from kubernetes-csi/dependabot/github_actions/actions/checkout-5 458ce146f Bump actions/checkout from 4 to 5 5f38a9075 Merge pull request kubernetes-csi#282 from rhrmo/update-go-1.24.6 579f62421 Update go to 1.24.6 5ec1a52b8 use gcr.io/k8s-staging-test-infra instead of gcr.io/k8s-testimages 74e066a82 Merge pull request kubernetes-csi#279 from Aishwarya-Hebbar/update-csi-prow-version 6f236be7d Update CSI prow driver version to v1.17.0 0ee55894b Merge pull request kubernetes-csi#280 from xing-yang/update_go_1.24.4 9af101534 update to go 1.24.4 f5fec3e36 Merge pull request kubernetes-csi#275 from chrishenzie/emeritus c5d285db8 Remove chrishenzie from kubernetes-csi-reviewers 0a435bf98 Merge pull request kubernetes-csi#274 from andyzhangx/patch-5 cd7b4bba3 Bump golang to 1.24.2 to fix CVE-2025-22871 701dc34bc Merge pull request kubernetes-csi#273 from andyzhangx/patch-4 aeebd30e8 Bump golang to 1.24.0 f277d561f Merge pull request kubernetes-csi#270 from carlory/update-kind-version 6dcb96a51 update default kind version to v0.25.0 git-subtree-dir: release-tools git-subtree-split: 119a53c3cce0c04fd422514252ea62c6ff4e3548
119a53c3c Merge pull request kubernetes-csi#294 from andyzhangx/patch-10 7c9aa9ba3 fix: upgrade to go1.25.7 to fix CVE-2026-25679 1e81e752e Merge pull request kubernetes-csi#293 from andyzhangx/patch-9 4dc185057 fix: upgrade to go1.25.7 to fix CVE-2025-61727 b60b9a507 Merge pull request kubernetes-csi#292 from andyzhangx/patch-8 0e4e2ed0d Update Go version from 1.25.5 to 1.25.6 to fix CVE 707a99eca Merge pull request kubernetes-csi#291 from dfajmon/logcheck a9d2b0fb3 Bump logcheck to v0.10.0 d6846630b Merge pull request kubernetes-csi#290 from dfajmon/go-1.25.5 55e527c49 Bump golang to 1.25.5 b12e407cc Merge pull request kubernetes-csi#289 from nixpanic/k8s-v1.34 bbe5e547e Use Kubernetes v1.34 and Kind v0.30 by default 4e9eb2c9e Merge pull request kubernetes-csi#288 from gnufied/add-gnufied-for-csi-approver 064e260d9 Add myself as csi approver c852fa797 Merge pull request kubernetes-csi#287 from andyzhangx/patch-7 bce16c103 fix: upgrade to go1.24.11 to fix CVE-2025-61727 8d1258cce Merge pull request kubernetes-csi#286 from kubernetes-csi/dependabot/github_actions/actions/checkout-6 91e35981a Bump actions/checkout from 5 to 6 294138155 Merge pull request kubernetes-csi#285 from andyzhangx/patch-6 fa8b339e9 fix: upgrade to go1.24.9 to fix CVEs 74502e544 Merge pull request kubernetes-csi#278 from liangyuanpeng/migrate_k8s_testimages 533443055 Merge pull request kubernetes-csi#281 from kubernetes-csi/dependabot/github_actions/actions/checkout-5 458ce146f Bump actions/checkout from 4 to 5 5f38a9075 Merge pull request kubernetes-csi#282 from rhrmo/update-go-1.24.6 579f62421 Update go to 1.24.6 5ec1a52b8 use gcr.io/k8s-staging-test-infra instead of gcr.io/k8s-testimages 74e066a82 Merge pull request kubernetes-csi#279 from Aishwarya-Hebbar/update-csi-prow-version 6f236be7d Update CSI prow driver version to v1.17.0 0ee55894b Merge pull request kubernetes-csi#280 from xing-yang/update_go_1.24.4 9af101534 update to go 1.24.4 f5fec3e36 Merge pull request kubernetes-csi#275 from chrishenzie/emeritus c5d285db8 Remove chrishenzie from kubernetes-csi-reviewers 0a435bf98 Merge pull request kubernetes-csi#274 from andyzhangx/patch-5 cd7b4bba3 Bump golang to 1.24.2 to fix CVE-2025-22871 701dc34bc Merge pull request kubernetes-csi#273 from andyzhangx/patch-4 aeebd30e8 Bump golang to 1.24.0 f277d561f Merge pull request kubernetes-csi#270 from carlory/update-kind-version 6dcb96a51 update default kind version to v0.25.0 git-subtree-dir: release-tools git-subtree-split: 119a53c3cce0c04fd422514252ea62c6ff4e3548
What type of PR is this?
/kind flake
What this PR does / why we need it:
There were some instances where a namespace remained after a test due to a VolumeSnapshot persisted after the associated objects (VolumeSnapshotContent/PVC) and VolumeSnapshotClass had been deleted. If the cluster entered into this state, then the namespace would remain until the VolumeSnapshot was manually removed.
This PR allows a VolumeSnapshot that's been scheduled for deletion to be successfully deleted if the VolumeSnapshotClass cannot be found.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
Does this PR introduce a user-facing change?: