Update kube vendor dependency and others

[humblec]

Signed-off-by: Humble Chirammal hchiramm@redhat.com

-->

With kubernetes 1.18 release of client-go, signatures on methods in generated clientsets, dynamic, metadata, and scale clients have been modified to accept context.Context as a first argument. Signatures of Create, Update, and Patch methods have been updated to accept CreateOptions, UpdateOptions and PatchOptions respectively. Signatures of Delete and DeleteCollection methods now accept DeleteOptions by value instead of by reference.  These changes are now accommodated with this PR and client-go and dependencies are updated to v1.18.0

[k8s-ci-robot]

Hi @humblec. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[msau42]

/ok-to-test

[humblec]

/release-note-none

[humblec]

@xing-yang @msau42 removing WIP as the CI is passing now. I have changed some function calls too to accomodate params like ctx ..etc to satisfy new invokation of api calls. Please review.

[humblec]

@xing-yang looks we are close to get the CI passing , the last errors what I see atm:

...
mkdir -p bin
CGO_ENABLED=0 GOOS=linux go build -mod=vendor -a -ldflags '-X main.version=v2.1.0-4-g4670775a -extldflags "-static"' -o ./bin/csi-snapshotter ./cmd/csi-snapshotter
# github.com/kubernetes-csi/external-snapshotter/v2/pkg/sidecar-controller
pkg/sidecar-controller/snapshot_controller.go:613:89: not enough arguments in call to ctrl.clientset.SnapshotV1beta1().VolumeSnapshotContents().Update
	have (*"github.com/kubernetes-csi/external-snapshotter/v2/pkg/apis/volumesnapshot/v1beta1".VolumeSnapshotContent)
	want (context.Context, *"github.com/kubernetes-csi/external-snapshotter/v2/pkg/apis/volumesnapshot/v1beta1".VolumeSnapshotContent, "k8s.io/apimachinery/pkg/apis/meta/v1".UpdateOptions)
pkg/sidecar-controller/snapshot_controller.go:639:89: not enough arguments in call to ctrl.clientset.SnapshotV1beta1().VolumeSnapshotContents().Update
	have (*"github.com/kubernetes-csi/external-snapshotter/v2/pkg/apis/volumesnapshot/v1beta1".VolumeSnapshotContent)
	want (context.Context, *"github.com/kubernetes-csi/external-snapshotter/v2/pkg/apis/volumesnapshot/v1beta1".VolumeSnapshotContent, "k8s.io/apimachinery/pkg/apis/meta/v1".UpdateOptions)
make: *** [release-tools/build.make:70: build-csi-snapshotter] Error 2

[xing-yang]

@humblec This looks like the files under v2/pkg are not pointing to files directly under pkg. So I suspect that you missed some steps to remove everything before running the script. Can you follow the README and retry?

rm -fr v2/
ln -sfvn $(pwd) v2
rm -fr pkg/client

[xing-yang]

@humblec Let's wait until we are done with cherry-pick. Thanks.

[humblec]

@humblec Let's wait until we are done with cherry-pick. Thanks.

@xing-yang sure.. meanwhile I was just trying to rebase and get back to shape :)

[humblec]

/retest

[Madhu-1]

@xing-yang will snapshot 2.1.1 includes this PR? will this be part of the next release? if yes when we can expect a release of snapshotter with this change.

[humblec]

Rebased to master again @xing-yang.
Make output :

+ CGO_ENABLED=0
+ GOOS=
+ GOARCH=
+ go build -a -ldflags '-X main.version=v2.1.0-23-gdac1c5f9 -extldflags "-static"' -o ./bin/csi-snapshotter ./cmd/csi-snapshotter
[root@localhost external-snapshotter]#

[xing-yang]

@humblec, we don't need node-api, sample-cli-plugin, and sample-controller in go.mod. I could build without them. Please remove them from go.mod. Other than that, it looks good.

# git diff go.mod
diff --git a/go.mod b/go.mod
index bfb54dcd..e616b80c 100644
--- a/go.mod
+++ b/go.mod
-replace k8s.io/node-api => k8s.io/node-api v0.18.0
-
-replace k8s.io/sample-cli-plugin => k8s.io/sample-cli-plugin v0.18.0
-
-replace k8s.io/sample-controller => k8s.io/sample-controller v0.18.0
-

[humblec]

@humblec, we don't need node-api, sample-cli-plugin, and sample-controller in go.mod. I could build without them. Please remove them from go.mod. Other than that, it looks good.

@xing-yang True, I could build as well, Removed from the patchset. Thanks 👍

[xing-yang]

Can you squash your commits?

[humblec]

Can you squash your commits?

@xing-yang Done. Only 1 commit at current patchset.

[humblec]

/retest

[xing-yang]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: humblec, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [xing-yang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Madhu-1]

@xing-yang can you please remove hold label from this PR?

[xing-yang]

/hold cancel