Add event for snapshotting in progress by zhucan · Pull Request #289 · kubernetes-csi/external-snapshotter

zhucan · 2020-04-09T14:02:56Z

Signed-off-by: zhuc zhucan.k8s@gmail.com

What type of PR is this?

/kind feature

What this PR does / why we need it:
Need to add an event on the VolumeSnapshot API object after we've created VolumeSnapshotContent in the common controller

Which issue(s) this PR fixes:

Fixes #268

Special notes for your reviewer:
@xing-yang

Does this PR introduce a user-facing change?:

Add event for snapshotting in progress

k8s-ci-robot · 2020-04-09T14:02:59Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

pkg/common-controller/snapshot_controller.go

xing-yang · 2020-04-29T02:54:57Z

/lgtm
/approve

yuxiangqian · 2020-04-29T03:44:14Z

this needs rebase as a bug fix has been recently checked-in. :(. @zhucan

xing-yang · 2020-04-29T14:53:17Z

@zhucan please rebase.

Signed-off-by: zhuc <zhucan@xsky.com>

zhucan · 2020-04-30T02:29:02Z

@xing-yang @yuxiangqian done

xing-yang · 2020-04-30T10:54:21Z

/lgtm
/approve

k8s-ci-robot · 2020-04-30T10:54:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xing-yang, zhucan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [xing-yang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

b12e407cc Merge pull request kubernetes-csi#289 from nixpanic/k8s-v1.34 bbe5e547e Use Kubernetes v1.34 and Kind v0.30 by default 4e9eb2c9e Merge pull request kubernetes-csi#288 from gnufied/add-gnufied-for-csi-approver 064e260d9 Add myself as csi approver c852fa797 Merge pull request kubernetes-csi#287 from andyzhangx/patch-7 bce16c103 fix: upgrade to go1.24.11 to fix CVE-2025-61727 git-subtree-dir: release-tools git-subtree-split: b12e407cc9556acf6702ed8745d3f8a29c9169bb

k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 9, 2020

k8s-ci-robot requested review from jingxu97 and yuxiangqian April 9, 2020 14:02

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 9, 2020

zhucan force-pushed the bugfix-268 branch from 3b73043 to 6d79400 Compare April 9, 2020 14:05

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 9, 2020

xing-yang reviewed Apr 9, 2020

View reviewed changes