Update Knative Serving/Eventing/Build GCS bucket#26
Merged
google-prow-robot merged 2 commits intoknative:masterfrom Jul 23, 2018
adrcunha:separate-releases
Merged
Update Knative Serving/Eventing/Build GCS bucket#26google-prow-robot merged 2 commits intoknative:masterfrom adrcunha:separate-releases
google-prow-robot merged 2 commits intoknative:masterfrom
adrcunha:separate-releases
Conversation
Contributor
adrcunha
commented
Jul 23, 2018
adrcunha
commented
- Knative Serving release was moved to its own directory in Release Knative Serving YAML into its own subdirectory in GCS serving#1654.
- Knative Build release was moved to its own directory in Release Knative Build YAML into its own subdirectory in GCS build#279.
- Knative Eventing release was moved to its own directory in Release Knative Eventing YAMLs into their own subdirectory in GCS eventing#265.
* Knative Serving release was moved to its own directory in knative/serving#1654. * Knative Build release was moved to its own directory in knative/build#279. * Knative Eventing release was moved to its own directory in knative/eventing#265.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrcunha The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-prow-robot
added
the
approved
google-prow-robot
added
the
size/XS
Contributor
Author
|
/hold This must be merged and a new prow-tests image built once the aforementioned PRs are merged and new releases are cut. |
google-prow-robot
added
the
do-not-merge/hold
Contributor
|
/lgtm |
google-prow-robot
added
lgtm
Contributor
|
/lgtm |
jessiezcc
reviewed
Jul 23, 2018
| readonly KNATIVE_ISTIO_YAML=https://storage.googleapis.com/knative-releases/serving/latest/istio.yaml | ||
| readonly KNATIVE_SERVING_RELEASE=https://storage.googleapis.com/knative-releases/serving/latest/release.yaml | ||
| readonly KNATIVE_BUILD_RELEASE=https://storage.googleapis.com/build-crd/latest/build/release.yaml | ||
|
|
Contributor
There was a problem hiding this comment.
should u change event release to be under eventing subfolder as well?
Contributor
Author
There was a problem hiding this comment.
Yes, see the PR mentioned in the PR description. This PR needs to be rebased once #25 is in.
jessiezcc
reviewed
Jul 23, 2018
images/prow-tests/scripts/library.sh
Outdated
| readonly KNATIVE_BUILD_RELEASE=https://storage.googleapis.com/build-crd/latest/release.yaml | ||
| readonly KNATIVE_ISTIO_YAML=https://storage.googleapis.com/knative-releases/serving/latest/istio.yaml | ||
| readonly KNATIVE_SERVING_RELEASE=https://storage.googleapis.com/knative-releases/serving/latest/release.yaml | ||
| readonly KNATIVE_BUILD_RELEASE=https://storage.googleapis.com/build-crd/latest/build/release.yaml |
Contributor
There was a problem hiding this comment.
build-crd instead of knative-releases? we don't consider build-crd as part of knative-releases?
Contributor
Author
There was a problem hiding this comment.
No. build-crd GCR is no more. See knative/build#276
Contributor
|
/lgtm |
Contributor
Author
|
/hold cancel |
google-prow-robot
removed
the
do-not-merge/hold
adrcunha
added a commit
that referenced
this pull request
Aug 6, 2018
* Knative Serving release was moved to its own directory in knative/serving#1654. * Knative Build release was moved to its own directory in knative/build#279. * Knative Eventing release was moved to its own directory in knative/eventing#265.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.