Skip to content

Update the location of build releases#25

Merged
google-prow-robot merged 1 commit intoknative:masterfrom
adrcunha:update-build-release-location
Jul 23, 2018
Merged

Update the location of build releases#25
google-prow-robot merged 1 commit intoknative:masterfrom
adrcunha:update-build-release-location

Conversation

@adrcunha
Copy link
Copy Markdown
Contributor

In knative/build#276 the releases moved to the knative-releases GCR

Bonus: add the location of eventing releases.

In knative/build#276 the releases moved to the knative-releases GCR

Bonus: add the location of eventing releases.
@google-prow-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrcunha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-prow-robot google-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2018
@google-prow-robot google-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 23, 2018
@adrcunha
Copy link
Copy Markdown
Contributor Author

/hold

knative/build#276 must be merged first and a release cut so this PR can be merged and a new prow-tests image generated.

@google-prow-robot google-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 23, 2018
@adrcunha adrcunha requested review from jessiezcc and removed request for steuhs July 23, 2018 05:38
@adrcunha
Copy link
Copy Markdown
Contributor Author

/hold cancel

@google-prow-robot google-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 23, 2018
readonly KNATIVE_ISTIO_YAML=https://storage.googleapis.com/knative-releases/latest/istio.yaml
readonly KNATIVE_SERVING_RELEASE=https://storage.googleapis.com/knative-releases/latest/release.yaml
readonly KNATIVE_BUILD_RELEASE=https://storage.googleapis.com/build-crd/latest/release.yaml
readonly KNATIVE_BUILD_RELEASE=https://storage.googleapis.com/knative-releases/latest/release-build.yaml
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both #25 and #26 change build release, which is right?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following the order, 26. I'll merge this first and rebase 26.

@jessiezcc
Copy link
Copy Markdown
Contributor

/lgtm

@google-prow-robot google-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2018
@google-prow-robot google-prow-robot merged commit 49b29c9 into knative:master Jul 23, 2018
@adrcunha adrcunha deleted the update-build-release-location branch July 23, 2018 20:41
adrcunha added a commit that referenced this pull request Aug 6, 2018
In knative/build#276 the releases moved to the knative-releases GCR

Bonus: add the location of eventing releases.
Cynocracy pushed a commit to Cynocracy/test-infra that referenced this pull request Jun 13, 2020
Cynocracy pushed a commit to Cynocracy/test-infra that referenced this pull request Jul 22, 2020
Produced via:
  `./hack/update-deps.sh --upgrade && ./hack/update-codegen.sh`
/assign tcnghia
/cc tcnghia
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants