Skip to content

Update Knative Serving/Eventing/Build GCS bucket #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
google-prow-robot merged 2 commits into from
Jul 23, 2018
Merged

Update Knative Serving/Eventing/Build GCS bucket #26

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b967a4e
Update Knative Serving/Eventing/Build GCS bucket
adrcunha Jul 23, 2018
f3833f2
Merge branch 'master' into separate-releases
adrcunha Jul 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions images/prow-tests/scripts/library.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@ readonly SERVING_GKE_VERSION=latest
readonly SERVING_GKE_IMAGE=cos

# Public images and yaml files.
readonly KNATIVE_ISTIO_YAML=https://storage.googleapis.com/knative-releases/latest/istio.yaml
readonly KNATIVE_SERVING_RELEASE=https://storage.googleapis.com/knative-releases/latest/release.yaml
readonly KNATIVE_BUILD_RELEASE=https://storage.googleapis.com/build-crd/latest/release.yaml
readonly KNATIVE_ISTIO_YAML=https://storage.googleapis.com/knative-releases/serving/latest/istio.yaml
readonly KNATIVE_SERVING_RELEASE=https://storage.googleapis.com/knative-releases/serving/latest/release.yaml
readonly KNATIVE_BUILD_RELEASE=https://storage.googleapis.com/build-crd/latest/build/release.yaml

@jessiezcc jessiezcc Jul 23, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build-crd instead of knative-releases? we don't consider build-crd as part of knative-releases?

@adrcunha adrcunha Jul 23, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. build-crd GCR is no more. See knative/build#276


@jessiezcc jessiezcc Jul 23, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should u change event release to be under eventing subfolder as well?

@adrcunha adrcunha Jul 23, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, see the PR mentioned in the PR description. This PR needs to be rebased once #25 is in.

# Flag that this script was loaded.
readonly KNATIVE_TEST_INFRA=1
Expand Down