Release Knative Eventing YAMLs into their own subdirectory in GCS#265
Merged
google-prow-robot merged 1 commit intoknative:masterfrom Jul 23, 2018
adrcunha:separate-releases
Merged
Release Knative Eventing YAMLs into their own subdirectory in GCS#265google-prow-robot merged 1 commit intoknative:masterfrom adrcunha:separate-releases
google-prow-robot merged 1 commit intoknative:masterfrom
adrcunha:separate-releases
Conversation
Doing so clearly separates the components and avoids confusion with the other releases that are build on the same day. Also remove the "-eventing-" part of the YAML filenames for simplification.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrcunha The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-prow-robot
added
the
approved
google-prow-robot
added
the
size/S
grantr
approved these changes
Jul 23, 2018
Contributor
There was a problem hiding this comment.
/lgtm
Just want to note that this makes it slightly more difficult to download the various release.yaml files for inspection because they all have the same name. Since the docs direct users to pipe the downloaded content into kubectl, I'm fine with the download for inspection case being more difficult.
google-prow-robot
pushed a commit
to knative/test-infra
that referenced
this pull request
Jul 23, 2018
* Knative Serving release was moved to its own directory in knative/serving#1654. * Knative Build release was moved to its own directory in knative/build#279. * Knative Eventing release was moved to its own directory in knative/eventing#265.
adrcunha
added a commit
to knative/test-infra
that referenced
this pull request
Aug 6, 2018
* Knative Serving release was moved to its own directory in knative/serving#1654. * Knative Build release was moved to its own directory in knative/build#279. * Knative Eventing release was moved to its own directory in knative/eventing#265.
pierDipi
added a commit
to pierDipi/eventing
that referenced
this pull request
Jul 20, 2023
* Refactor PingSource adapter client creation (knative#6880) This is just a refactoring to make it easier to implement Eventing TLS Part of knative#6879 --------- Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Send namespace header in MT components (knative#7048) When running MT components [1] in mesh mode with Istio, we lose the ability to define fine grained policies since we don't know the resource namespace that originated such request, therefore, by having a `Kn-Namespace` header, in mesh mode, users case define fine-grained policies and isolate namespaces. [1] IMC, MTChannelBasedBroker, and PingSource Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Fix compile error Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> --------- Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi
added a commit
to pierDipi/eventing
that referenced
this pull request
Jul 20, 2023
* Refactor PingSource adapter client creation (knative#6880) This is just a refactoring to make it easier to implement Eventing TLS Part of knative#6879 --------- Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Send namespace header in MT components (knative#7048) When running MT components [1] in mesh mode with Istio, we lose the ability to define fine grained policies since we don't know the resource namespace that originated such request, therefore, by having a `Kn-Namespace` header, in mesh mode, users case define fine-grained policies and isolate namespaces. [1] IMC, MTChannelBasedBroker, and PingSource Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Fix compile error Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> --------- Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi
added a commit
to pierDipi/eventing
that referenced
this pull request
Jul 21, 2023
…native#278) * Refactor PingSource adapter client creation (knative#6880) This is just a refactoring to make it easier to implement Eventing TLS Part of knative#6879 --------- * Send namespace header in MT components (knative#7048) When running MT components [1] in mesh mode with Istio, we lose the ability to define fine grained policies since we don't know the resource namespace that originated such request, therefore, by having a `Kn-Namespace` header, in mesh mode, users case define fine-grained policies and isolate namespaces. [1] IMC, MTChannelBasedBroker, and PingSource * Fix compile error --------- Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi
added a commit
to pierDipi/eventing
that referenced
this pull request
Jul 25, 2023
* Refactor PingSource adapter client creation (knative#6880) This is just a refactoring to make it easier to implement Eventing TLS Part of knative#6879 --------- Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Send namespace header in MT components (knative#7048) When running MT components [1] in mesh mode with Istio, we lose the ability to define fine grained policies since we don't know the resource namespace that originated such request, therefore, by having a `Kn-Namespace` header, in mesh mode, users case define fine-grained policies and isolate namespaces. [1] IMC, MTChannelBasedBroker, and PingSource Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Fix compile error Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> --------- Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doing so clearly separates the components and avoids confusion with the other releases that are build on the same day.
Also remove the "-eventing-" part of the YAML filenames for simplification.