Skip to content

Initial version of release.sh helper in prow-tests image#14

Merged
google-prow-robot merged 3 commits intoknative:masterfrom
adrcunha:release-helper
Jul 19, 2018
Merged

Initial version of release.sh helper in prow-tests image#14
google-prow-robot merged 3 commits intoknative:masterfrom
adrcunha:release-helper

Conversation

@adrcunha
Copy link
Copy Markdown
Contributor

This helper manages flag parsing and test skipping, leaving the real script in the repos with only the important stuff (i.e., building the release).

This will reduce boilerplate code and unify the release strategy and features across the repos.

@google-prow-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrcunha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-prow-robot google-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2018
@google-prow-robot google-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 18, 2018
@knative knative deleted a comment from google-prow-robot Jul 19, 2018
adrcunha added 2 commits July 19, 2018 00:30
This helper manages flag parsing and test skipping, leaving the real script in the repos with only the important stuff (i.e., building the release).

This will reduce boilerplate code and unify the release strategy and features across the repos.
@knative knative deleted a comment from google-prow-robot Jul 19, 2018
@srinivashegde86
Copy link
Copy Markdown
Contributor

/lgtm

@google-prow-robot google-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2018
@google-prow-robot google-prow-robot merged commit fb50147 into knative:master Jul 19, 2018
@adrcunha adrcunha deleted the release-helper branch July 19, 2018 18:13
google-prow-robot pushed a commit to knative/build that referenced this pull request Jul 22, 2018
We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features.

`release.sh` helper is implemented by knative/test-infra#14

**Bonus!** Now build-crd release script has the following features, just like serving and eventing:
* setting custom GCR/GCS buckets through environment variables
* release tagging
* test skipping
* local build
google-prow-robot pushed a commit to knative/eventing that referenced this pull request Jul 22, 2018
We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features.

release.sh helper is implemented by knative/test-infra#14
adrcunha added a commit that referenced this pull request Aug 6, 2018
This helper manages flag parsing and test skipping, leaving the real script in the repos with only the important stuff (i.e., building the release).

This will reduce boilerplate code and unify the release strategy and features across the repos.
vdemeester pushed a commit to vdemeester/knative-build that referenced this pull request Apr 3, 2019
We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features.

`release.sh` helper is implemented by knative/test-infra#14

**Bonus!** Now build-crd release script has the following features, just like serving and eventing:
* setting custom GCR/GCS buckets through environment variables
* release tagging
* test skipping
* local build
vdemeester pushed a commit to vdemeester/knative-build that referenced this pull request Apr 3, 2019
We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features.

`release.sh` helper is implemented by knative/test-infra#14

**Bonus!** Now build-crd release script has the following features, just like serving and eventing:
* setting custom GCR/GCS buckets through environment variables
* release tagging
* test skipping
* local build
Cynocracy pushed a commit to Cynocracy/test-infra that referenced this pull request Jul 22, 2020
Produced via:
  `./hack/update-deps.sh --upgrade && ./hack/update-codegen.sh`
/assign tcnghia
/cc tcnghia
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants