Skip to content

Use release.sh helper from prow-tests image#1622

Merged
google-prow-robot merged 3 commits intoknative:masterfrom
adrcunha:simpler-release-sh
Jul 21, 2018
Merged

Use release.sh helper from prow-tests image#1622
google-prow-robot merged 3 commits intoknative:masterfrom
adrcunha:simpler-release-sh

Conversation

@adrcunha
Copy link
Copy Markdown
Contributor

@adrcunha adrcunha commented Jul 19, 2018

We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features.

release.sh helper is implemented by knative/test-infra#14

We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features.
@google-prow-robot google-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 19, 2018
@adrcunha adrcunha requested review from mattmoor and removed request for vaikas July 19, 2018 07:27
Copy link
Copy Markdown
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that a human cannot run release.sh?

@adrcunha
Copy link
Copy Markdown
Contributor Author

No, any human can run release.sh. It works as usual.

Copy link
Copy Markdown
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-prow-robot google-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2018
@google-prow-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrcunha, mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-prow-robot google-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2018
@google-prow-robot google-prow-robot merged commit 937d5a9 into knative:master Jul 21, 2018
@adrcunha adrcunha deleted the simpler-release-sh branch July 21, 2018 02:17
bbrowning pushed a commit to bbrowning/serving that referenced this pull request Oct 5, 2018
* Use release.sh helper from prow-tests image

We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features.

* Update comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants