This repository was archived by the owner on Sep 5, 2019. It is now read-only.
Use release.sh helper from prow-tests image#270
Merged
google-prow-robot merged 1 commit intoknative:masterfrom Jul 22, 2018
adrcunha:better-release
Merged
Use release.sh helper from prow-tests image#270google-prow-robot merged 1 commit intoknative:masterfrom adrcunha:better-release
google-prow-robot merged 1 commit intoknative:masterfrom
adrcunha:better-release
Conversation
We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features. `release.sh` helper is implemented by knative/test-infra#14 **Bonus!** Now build-crd release script has the following features, just like serving and eventing: * setting custom GCR/GCS buckets through environment variables * release tagging * test skipping * local build
imjasonh
reviewed
Jul 20, 2018
|
|
||
| # Set default GCS/GCR | ||
| : ${BUILD_RELEASE_GCS:="build-crd"} | ||
| : ${BUILD_RELEASE_GCR:="gcr.io/build-crd"} |
Contributor
There was a problem hiding this comment.
Can we move these to where serving and eventing put their releases? Which I believe is knative-releases?
Contributor
Author
There was a problem hiding this comment.
We can and I'm happy to do that, but last time I talked to @mattmoor about this, he wanted to keep them in separate GCRs. Matt?
Member
There was a problem hiding this comment.
knative-releases seems fine. This was just trickier when it was elafros.
|
/lgtm |
Member
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrcunha, mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
vdemeester
pushed a commit
to vdemeester/knative-build
that referenced
this pull request
Apr 3, 2019
We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features. `release.sh` helper is implemented by knative/test-infra#14 **Bonus!** Now build-crd release script has the following features, just like serving and eventing: * setting custom GCR/GCS buckets through environment variables * release tagging * test skipping * local build
vdemeester
pushed a commit
to vdemeester/knative-build
that referenced
this pull request
Apr 3, 2019
We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features. `release.sh` helper is implemented by knative/test-infra#14 **Bonus!** Now build-crd release script has the following features, just like serving and eventing: * setting custom GCR/GCS buckets through environment variables * release tagging * test skipping * local build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features.
release.shhelper is implemented by knative/test-infra#14Bonus! Now build-crd release script has the following features, just like serving and eventing:
Fixes #267