Skip to content

Use release.sh helper from prow-tests image#237

Merged
google-prow-robot merged 3 commits intoknative:masterfrom
adrcunha:simpler-release
Jul 22, 2018
Merged

Use release.sh helper from prow-tests image#237
google-prow-robot merged 3 commits intoknative:masterfrom
adrcunha:simpler-release

Conversation

@adrcunha
Copy link
Copy Markdown
Contributor

@adrcunha adrcunha commented Jul 19, 2018

We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features.

release.sh helper is implemented by knative/test-infra#14

Bonuses:

  • fixes the clusterbus releases (the yaml files were being generated locally, but never published)
  • simplify generating new yamls through array+loop instead of duplicating code

We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features.

release.sh helper is implemented by knative/test-infra#14
@adrcunha adrcunha requested review from scothis and trisberg July 19, 2018 20:23
@google-prow-robot google-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 19, 2018
@jessiezcc
Copy link
Copy Markdown

/lgtm

@google-prow-robot google-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2018
@google-prow-robot google-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2018
@jessiezcc
Copy link
Copy Markdown

/lgtm
/approve

@google-prow-robot google-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2018
@adrcunha adrcunha requested review from mattmoor and vaikas and removed request for inlined, scothis, trisberg and ultrasaurus July 21, 2018 21:15
@mattmoor
Copy link
Copy Markdown
Member

/approve

@google-prow-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrcunha, jessiezcc, mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-prow-robot google-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2018
@google-prow-robot google-prow-robot merged commit b80fa9b into knative:master Jul 22, 2018
mgencur added a commit to mgencur/eventing that referenced this pull request May 30, 2023
* Replace min kube version from v1.25.0 to v1.21.0

* Remove 005-k8s-min.patch for patching minKubeVersion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants