Initial version of presubmit-tests.sh helper in prow-tests image#12
Merged
google-prow-robot merged 2 commits intoknative:masterfrom Jul 18, 2018
adrcunha:presubmit-helper
Merged
Initial version of presubmit-tests.sh helper in prow-tests image#12google-prow-robot merged 2 commits intoknative:masterfrom adrcunha:presubmit-helper
google-prow-robot merged 2 commits intoknative:masterfrom
adrcunha:presubmit-helper
Conversation
This helper manages flag parsing and presubmit skipping, leaving the real script in the repos with only the important stuff (i.e., running the tests themselves). This will reduce boilerplate code and unify the testing strategy and features for presubmits across ther repos.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrcunha The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-prow-robot
added
the
approved
google-prow-robot
added
the
size/L
Contributor
|
/lgtm |
This was referenced Jul 19, 2018
google-prow-robot
pushed a commit
to knative/build
that referenced
this pull request
Jul 19, 2018
We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features. `presubmit-tests.sh` helper is implemented by knative/test-infra#12
This was referenced Jul 19, 2018
google-prow-robot
pushed a commit
to knative/serving
that referenced
this pull request
Jul 20, 2018
We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features. presubmit-tests.sh helper is implemented by knative/test-infra#12
This was referenced Jul 21, 2018
google-prow-robot
pushed a commit
that referenced
this pull request
Jul 21, 2018
We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features. `presubmit-tests.sh` helper was implemented by #12
google-prow-robot
pushed a commit
to knative/eventing
that referenced
this pull request
Jul 21, 2018
We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features. presubmit-tests.sh helper is implemented by knative/test-infra#12
google-prow-robot
pushed a commit
to knative/docs
that referenced
this pull request
Jul 21, 2018
* Use helpers from prow-tests image for tests We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features. `presubmit-tests.sh` helper is implemented by knative/test-infra#12 `e2e-tests.sh` helper is implemented by knative/test-infra#17 * Explicitly fail test if setup fails
google-prow-robot
pushed a commit
to knative/docs
that referenced
this pull request
Jul 21, 2018
We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features. presubmit-tests.sh helper is implemented by knative/test-infra#12
adrcunha
added a commit
that referenced
this pull request
Aug 6, 2018
* Initial version of presubmit-tests.sh helper in prow-tests image This helper manages flag parsing and presubmit skipping, leaving the real script in the repos with only the important stuff (i.e., running the tests themselves). This will reduce boilerplate code and unify the testing strategy and features for presubmits across ther repos. * Reorganize source and clarify comments.
bbrowning
pushed a commit
to bbrowning/serving
that referenced
this pull request
Oct 5, 2018
We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features. presubmit-tests.sh helper is implemented by knative/test-infra#12
vdemeester
pushed a commit
to vdemeester/knative-build
that referenced
this pull request
Apr 3, 2019
We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features. `presubmit-tests.sh` helper is implemented by knative/test-infra#12
vdemeester
pushed a commit
to vdemeester/knative-build
that referenced
this pull request
Apr 3, 2019
We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features. `presubmit-tests.sh` helper is implemented by knative/test-infra#12
Cynocracy
pushed a commit
to Cynocracy/test-infra
that referenced
this pull request
Jul 22, 2020
* Add domain and realm CRDs Signed-off-by: Shash Reddy <shashwathireddy@gmail.com> * Update copyright headers Signed-off-by: Shash Reddy <shashwathireddy@gmail.com> * Add unit tests for domain and realm lifecycle Signed-off-by: Andrew Su <andrew.su.01@gmail.com> * Add unit tests for domain and realm types Signed-off-by: Andrew Su <andrew.su.01@gmail.com> * Add unit tests for realm and domain defaults Signed-off-by: Andrew Su <andrew.su.01@gmail.com> * Update copyright header Signed-off-by: Andrew Su <andrew.su.01@gmail.com> * Address comments * Update CRD verison to v1 * Make a copy of LBIngressStatus as LBImgressspec * gen reconciler changes * Update tests * Use IngressConfig struct instead of map type Signed-off-by: Shash Reddy <shashwathireddy@gmail.com> * Address comments Signed-off-by: Shash Reddy <shashwathireddy@gmail.com> * Address comments Signed-off-by: Shash Reddy <shashwathireddy@gmail.com> * Update codegen Signed-off-by: Shash Reddy <shashwathireddy@gmail.com> Co-authored-by: Shash Reddy <shashwathireddy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This helper manages flag parsing and presubmit skipping, leaving the real script in the repos with only the important stuff (i.e., running the tests themselves).
This will reduce boilerplate code and unify the testing strategy and features for presubmits across ther repos.