Skip to content

Use presubmit-tests.sh helper from prow-tests image#236

Merged
google-prow-robot merged 1 commit intoknative:masterfrom
adrcunha:simpler-presubmit
Jul 21, 2018
Merged

Use presubmit-tests.sh helper from prow-tests image#236
google-prow-robot merged 1 commit intoknative:masterfrom
adrcunha:simpler-presubmit

Conversation

@adrcunha
Copy link
Copy Markdown
Contributor

We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features.

presubmit-tests.sh helper is implemented by knative/test-infra#12

We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features.

presubmit-tests.sh helper is implemented by knative/test-infra#12
@google-prow-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrcunha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-prow-robot google-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2018
@google-prow-robot google-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 19, 2018
@jessiezcc
Copy link
Copy Markdown

/lgtm

@google-prow-robot google-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2018
@google-prow-robot google-prow-robot merged commit e34309e into knative:master Jul 21, 2018
pierDipi pushed a commit to pierDipi/eventing that referenced this pull request May 26, 2023
…e#236)

* Do not parse flags in InitializeEventingFlags

Provides better flexibility for reusing in downstream repositories.
It is now possible to initialize flags from this repo and any additional
flags from downstream repositories and then call flag.Parse explicitly
to fill the flags. Then it's possible to run RunMainTest independently.

This is especially useful when we want to combine REKT tests with
upgrade test suite.

* Do not pass -brokerclass as test argument

---------

Co-authored-by: Martin Gencur <mgencur@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants