Skip to content

Use helpers from prow-tests image for tests#232

Merged
google-prow-robot merged 2 commits intoknative:masterfrom
adrcunha:bye-library-sh
Jul 21, 2018
Merged

Use helpers from prow-tests image for tests#232
google-prow-robot merged 2 commits intoknative:masterfrom
adrcunha:bye-library-sh

Conversation

@adrcunha
Copy link
Copy Markdown
Contributor

We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features.

presubmit-tests.sh helper is implemented by knative/test-infra#12
e2e-tests.sh helper is implemented by knative/test-infra#17

We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features.

`presubmit-tests.sh` helper is implemented by knative/test-infra#12
`e2e-tests.sh` helper is implemented by knative/test-infra#17
@google-prow-robot google-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 21, 2018
@google-prow-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrcunha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adrcunha adrcunha requested review from jessiezcc and removed request for steuhs July 21, 2018 02:33
@adrcunha
Copy link
Copy Markdown
Contributor Author

/test pull-knative-docs-integration-tests

# limitations under the License.

# This script runs the end-to-end tests for build templates.
# This script runs the end-to-end tests.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we even need this for Docs repo?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, see #30.

@jessiezcc
Copy link
Copy Markdown
Contributor

/lgtm

@google-prow-robot google-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2018
@google-prow-robot google-prow-robot merged commit 72cb875 into knative:master Jul 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants