Skip to content

Use presubmit-tests.sh helper from prow-tests image#1628

Merged
google-prow-robot merged 1 commit intoknative:masterfrom
adrcunha:simpler-presubmit
Jul 20, 2018
Merged

Use presubmit-tests.sh helper from prow-tests image#1628
google-prow-robot merged 1 commit intoknative:masterfrom
adrcunha:simpler-presubmit

Conversation

@adrcunha
Copy link
Copy Markdown
Contributor

We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features.

presubmit-tests.sh helper is implemented by knative/test-infra#12

We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features.

presubmit-tests.sh helper is implemented by knative/test-infra#12
@google-prow-robot google-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 19, 2018
@google-prow-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrcunha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-prow-robot google-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2018
@adrcunha adrcunha requested review from jessiezcc and removed request for steuhs July 19, 2018 18:52
@jessiezcc
Copy link
Copy Markdown
Contributor

/lgtm

@google-prow-robot google-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2018
@google-prow-robot google-prow-robot merged commit cd1dc10 into knative:master Jul 20, 2018
bbrowning pushed a commit to bbrowning/serving that referenced this pull request Oct 5, 2018
We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features.

presubmit-tests.sh helper is implemented by knative/test-infra#12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants