Skip to content

Add julz to autoscaling approvers#8771

Merged
knative-prow-robot merged 1 commit intoknative:masterfrom
julz:ineedapproval
Jul 23, 2020
Merged

Add julz to autoscaling approvers#8771
knative-prow-robot merged 1 commit intoknative:masterfrom
julz:ineedapproval

Conversation

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 23, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 23, 2020
Copy link
Contributor

@markusthoemmes markusthoemmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAY, thanks for your continuous contributions to the WG! You're doing an awesome job questioning everything and keeping us honest too! The reviews you give are always thorough and constructive so I have 0 concerns upping your power level to be able to approve PRs for the WG! I trust your judgement 🙂.

Keep up the awesome work!

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: julz, markusthoemmes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2020
@mattmoor
Copy link
Member

+1 thanks @julz

@vagababov
Copy link
Contributor

/lgtm
/hold
for TOC approval.

@knative-prow-robot knative-prow-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Jul 23, 2020
@vagababov
Copy link
Contributor

Thanks a lot for your contributions!

@markusthoemmes
Copy link
Contributor

/unhold

No ToC needed and Matt and I approved anyway.

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 23, 2020
@knative-prow-robot knative-prow-robot merged commit 4ad5ab6 into knative:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants