Use configmap parser library from pkg.#7935
Use configmap parser library from pkg.#7935knative-prow-robot merged 1 commit intoknative:masterfrom
Conversation
knative-prow-robot
added
the
do-not-merge/work-in-progress
knative-prow-robot
added
size/XXL
knative-prow-robot
left a comment
knative-prow-robot
left a comment
There was a problem hiding this comment.
@markusthoemmes: 0 warnings.
Details
In response to this:
Proposed Changes
As the title says, uses some shared code moved into pkg here knative/pkg#1329.
Release Note
NONE
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
markusthoemmes
force-pushed
the
use-configmap-parser
branch
from
34b5264 to
1ab48ad
Compare
markusthoemmes
changed the title
knative-prow-robot
added
size/XL
markusthoemmes
force-pushed
the
use-configmap-parser
branch
from
1ab48ad to
1e464a6
Compare
pkg/network/network.go
Outdated
| defaultTagTemplate = template.Must(template.New("tag-template").Parse(DefaultTagTemplate)) | ||
| templateCache *lru.Cache | ||
|
|
||
| // Verify the default template are valid templates. |
There was a problem hiding this comment.
Uber-nit:
| // Verify the default template are valid templates. | |
| // Verify the default templates are valid. |
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
|
|
||
| "knative.dev/pkg/apis" | ||
| cm "knative.dev/pkg/configmap" |
There was a problem hiding this comment.
not wild about the import rename here, but I see why we're doing it so 🤷.
|
apart from the smallest nit ever, |
|
/lgtm |
|
/retest |
|
/test pull-knative-serving-integration-tests |
|
/test pull-knative-serving-integration-tests Yo prow, retry this! |
markusthoemmes
force-pushed
the
use-configmap-parser
branch
from
46ea9fb to
6da8a3a
Compare
knative-prow-robot
added
lgtm
markusthoemmes
force-pushed
the
use-configmap-parser
branch
from
6da8a3a to
10f0f78
Compare
knative-prow-robot
added
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markusthoemmes, mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
The following is the coverage report on the affected files.
|
|
The following jobs failed:
Automatically retrying due to test flakiness... |
8 participants
Proposed Changes
As the title says, uses some shared code moved into pkg here knative/pkg#1329.
Release Note